Skip to content

Add Richards's script to check for missing headers - #648

Merged
buechlerm merged 2 commits into
mainfrom
ci_check_missing_headers
Aug 10, 2026
Merged

Add Richards's script to check for missing headers#648
buechlerm merged 2 commits into
mainfrom
ci_check_missing_headers

Conversation

@buechlerm

Copy link
Copy Markdown
Collaborator

PR Summary

Add a github ci check to make sure all headers are registered.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@buechlerm

Copy link
Copy Markdown
Collaborator Author

Test is failing because it works as Richard suggested. It's catching: Headers missing register_headers() install logic:
singularity-eos/base/eos_concepts.hpp
singularity-eos/base/finite_diff.hpp
singularity-eos/closure/multiphase_material.hpp
singularity-eos/eos/eos_spiner_construction.hpp

Which actually includes one more than I found building flag: The multiphase_material.hpp file.

@Yurlungur were we intentionally hiding that for now or should I add that in #647?

@Yurlungur

Copy link
Copy Markdown
Collaborator

That's not intentional. We should add it.

@Yurlungur Yurlungur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@buechlerm
buechlerm merged commit d26d3e3 into main Aug 10, 2026
10 checks passed
@buechlerm
buechlerm deleted the ci_check_missing_headers branch August 10, 2026 13:54
@Yurlungur Yurlungur mentioned this pull request Aug 10, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants