Update API for non-CGS scattering variant, for MG changes. - #77
Merged
Conversation
RyanWollaeger
commented
Aug 2, 2026
RyanWollaeger
commented
Collaborator
- Testing in downstream software evidently revealed an API discrepancy from a stale scattering non-CGS mean variant.
- Update API for non-CGS scattering variant, following MG changes to CGS mean scattering base opacity.
Collaborator
Author
|
Worth sanity/double-checking this - it ended up being a sort of subtle error downstream. |
RyanWollaeger
force-pushed
the
up_noncgs_sct_api
branch
from
August 2, 2026 01:54
748d557 to
98f27de
Compare
3 tasks
pdmullen
approved these changes
Aug 3, 2026
Collaborator
Author
|
Thanks @pdmullen! Will go ahead and merge this to get a downstream changeset working - it is orthogonal to Alex's (and probably the other PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.