feat(testservice): support file-based flag overrides#416
Draft
kinyoklion wants to merge 3 commits into
Draft
Conversation
(cherry picked from commit 267384d)
…2657/testservice-flag-overrides
…2657/testservice-flag-overrides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens #413 (auto-marked merged for the same base-branch reason as #412; see #415). Rebuilt as a cherry-pick stacked on #415 so the diff shows only the test service changes. Review discussion lives on #413.
Wires the contract-test service up to the flag-overrides feature so the harness suite (launchdarkly/sdk-test-harness#374) can run against this SDK: advertises the
flag-overridescapability, mirrors the harness'soverridesconfig block in the test service'sservicedef, and maps it ontoldoverrides.FileSource()on the data system builder; requesting overrides without a data system configuration is an error, since overrides are an FDv2 feature.Verified locally against the harness branch: the flag-overrides suite passes in both watch and poll modes, and the full harness run (4945 tests) is green.
SDK-2657