Skip to content

feat(testservice): support file-based flag overrides#416

Draft
kinyoklion wants to merge 3 commits into
rlamb/sdk-2656/ldoverrides-file-sourcefrom
rlamb/sdk-2657/testservice-flag-overrides
Draft

feat(testservice): support file-based flag overrides#416
kinyoklion wants to merge 3 commits into
rlamb/sdk-2656/ldoverrides-file-sourcefrom
rlamb/sdk-2657/testservice-flag-overrides

Conversation

@kinyoklion

Copy link
Copy Markdown
Member

Reopens #413 (auto-marked merged for the same base-branch reason as #412; see #415). Rebuilt as a cherry-pick stacked on #415 so the diff shows only the test service changes. Review discussion lives on #413.

Wires the contract-test service up to the flag-overrides feature so the harness suite (launchdarkly/sdk-test-harness#374) can run against this SDK: advertises the flag-overrides capability, mirrors the harness's overrides config block in the test service's servicedef, and maps it onto ldoverrides.FileSource() on the data system builder; requesting overrides without a data system configuration is an error, since overrides are an FDv2 feature.

Verified locally against the harness branch: the flag-overrides suite passes in both watch and poll modes, and the full harness run (4945 tests) is green.

SDK-2657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant