build: Add ldmiddleware to "make bump-min-go-version"#419
Open
aaron-zeisler wants to merge 1 commit into
Open
Conversation
The bump-min-go-version Makefile target and the CONTRIBUTING docs both omitted ldmiddleware/go.mod, which was added after the target was written. Without this, the next minimum Go version bump would move the other four modules and go-versions.env forward while ldmiddleware silently stayed behind. No version value changes today; all five modules remain at go 1.24.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ldmiddlewareto thebump-min-go-versionMakefile target and the CONTRIBUTING docs.Background
The repo has five Go modules —
go.mod,ldotel/go.mod,ldai/go.mod,ldmiddleware/go.mod, andtestservice/go.mod— all currently ongo 1.24.0. Thebump-min-go-versiontarget is meant to move the minimum version across all of them (plusmin=in.github/variables/go-versions.env) in one shot.ldmiddlewarewas added after the target was written and never wired in. Both the Makefile target and the CONTRIBUTING file that documents it omitted it. The result is a latent drift bug: the next time someone runsmake bump-min-go-version MIN_GO_VERSION=1.25, the other four modules and the env file would advance whileldmiddlewaresilently stayed behind. It only lines up today because it was set manually.Changes
Makefile— add thecd ldmiddleware && go mod edit -go=$(MIN_GO_VERSION) go.modline alongside the other modules.CONTRIBUTING.md— addldmiddleware/go.modto the documented list of files the command updates.No version value changes; all five modules remain at
go 1.24.0. Verified by runningmake bump-min-go-version MIN_GO_VERSION=1.24.0(a no-op re-set) and confirming no unexpected diff.Note
Low Risk
Documentation and Makefile-only change to a maintainer tooling target; no runtime or dependency version changes.
Overview
Wires the
ldmiddlewareGo module into the shared minimum-Go bump workflow so it stays aligned with the other modules.make bump-min-go-versionnow runsgo mod editinldmiddlewarealongsidego.mod,ldotel,ldai, andtestservice, and CONTRIBUTING.md listsldmiddleware/go.modamong the files that command updates. No Go version values change in this PR.Reviewed by Cursor Bugbot for commit e525eb7. Bugbot is set up for automated code reviews on this repo. Configure here.