Skip to content

build: Add ldmiddleware to "make bump-min-go-version"#419

Open
aaron-zeisler wants to merge 1 commit into
v7from
aaronz/fix-ldmiddleware-go-version-bump
Open

build: Add ldmiddleware to "make bump-min-go-version"#419
aaron-zeisler wants to merge 1 commit into
v7from
aaronz/fix-ldmiddleware-go-version-bump

Conversation

@aaron-zeisler

@aaron-zeisler aaron-zeisler commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds ldmiddleware to the bump-min-go-version Makefile target and the CONTRIBUTING docs.

Background

The repo has five Go modules — go.mod, ldotel/go.mod, ldai/go.mod, ldmiddleware/go.mod, and testservice/go.mod — all currently on go 1.24.0. The bump-min-go-version target is meant to move the minimum version across all of them (plus min= in .github/variables/go-versions.env) in one shot.

ldmiddleware was added after the target was written and never wired in. Both the Makefile target and the CONTRIBUTING file that documents it omitted it. The result is a latent drift bug: the next time someone runs make bump-min-go-version MIN_GO_VERSION=1.25, the other four modules and the env file would advance while ldmiddleware silently stayed behind. It only lines up today because it was set manually.

Changes

  • Makefile — add the cd ldmiddleware && go mod edit -go=$(MIN_GO_VERSION) go.mod line alongside the other modules.
  • CONTRIBUTING.md — add ldmiddleware/go.mod to the documented list of files the command updates.

No version value changes; all five modules remain at go 1.24.0. Verified by running make bump-min-go-version MIN_GO_VERSION=1.24.0 (a no-op re-set) and confirming no unexpected diff.


Note

Low Risk
Documentation and Makefile-only change to a maintainer tooling target; no runtime or dependency version changes.

Overview
Wires the ldmiddleware Go module into the shared minimum-Go bump workflow so it stays aligned with the other modules.

make bump-min-go-version now runs go mod edit in ldmiddleware alongside go.mod, ldotel, ldai, and testservice, and CONTRIBUTING.md lists ldmiddleware/go.mod among the files that command updates. No Go version values change in this PR.

Reviewed by Cursor Bugbot for commit e525eb7. Bugbot is set up for automated code reviews on this repo. Configure here.

The bump-min-go-version Makefile target and the CONTRIBUTING docs both
omitted ldmiddleware/go.mod, which was added after the target was
written. Without this, the next minimum Go version bump would move the
other four modules and go-versions.env forward while ldmiddleware
silently stayed behind. No version value changes today; all five modules
remain at go 1.24.0.
@aaron-zeisler aaron-zeisler changed the title build: wire ldmiddleware into bump-min-go-version target build: Add ldmiddleware to "make bump-min-go-version" Jul 13, 2026
@aaron-zeisler aaron-zeisler changed the title build: Add ldmiddleware to "make bump-min-go-version" chore: Add ldmiddleware to "make bump-min-go-version" Jul 13, 2026
@aaron-zeisler aaron-zeisler changed the title chore: Add ldmiddleware to "make bump-min-go-version" build: Add ldmiddleware to "make bump-min-go-version" Jul 13, 2026
@aaron-zeisler aaron-zeisler marked this pull request as ready for review July 13, 2026 22:14
@aaron-zeisler aaron-zeisler requested a review from a team as a code owner July 13, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant