Skip to content

build: Add ldmiddleware to "make bump-min-go-version" #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-zeisler merged 1 commit into from
Jul 16, 2026
+3 −2
Merged

build: Add ldmiddleware to "make bump-min-go-version" #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ The SDK is tested against three Go versions: the latest, penultimate, and a mini
Whereas the latest and penultimate are updates on a regular cadence to track upstream Go releases, the minimum version
may be bumped at the discretion of the SDK maintainers to take advantage of new features.

Invoke the following make command, which will update `go.mod`, `ldotel/go.mod`, `ldai/go.mod`, `testservice/go.mod`, and
`.github/variables/go-versions.env` (pass the desired Go version):
Invoke the following make command, which will update `go.mod`, `ldotel/go.mod`, `ldai/go.mod`, `ldmiddleware/go.mod`,
`testservice/go.mod`, and `.github/variables/go-versions.env` (pass the desired Go version):
```shell
make bump-min-go-version MIN_GO_VERSION=1.18
```
Expand Down
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ bump-min-go-version:
go mod edit -go=$(MIN_GO_VERSION) go.mod
cd ldotel && go mod edit -go=$(MIN_GO_VERSION) go.mod
cd ldai && go mod edit -go=$(MIN_GO_VERSION) go.mod
cd ldmiddleware && go mod edit -go=$(MIN_GO_VERSION) go.mod
cd testservice && go mod edit -go=$(MIN_GO_VERSION) go.mod
cd ./.github/variables && sed -i.bak "s#min=[^ ]*#min=$(MIN_GO_VERSION)#g" go-versions.env && rm go-versions.env.bak

Expand Down
Loading