Draft
Conversation
Owner
|
Thanks for the draft - while it might not be faster yet, it should unlock some better performance both in theory (cache locality, esp for binary search) and enable some further downstream optimizations. Some ideas (not necessarily for us to implement now):
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#166 (comment)
This PR removes the
MS1Spectraand the generic peak/imspeak inProcessedSpectrumLMK if this is what you had in mind ... RN I am not the biggest fan of a couple of places in the processing where I am zipping->unzipping to sort the peaks (which is why I am leaving it as a draft for now).
In my benchmarking it is almost as fast as the other implementation (runtime is maybe 2% slower in my computer and that matches the number of instructions retired on some random data)
LMK what you think! (or feel free to take it as a base to go off ...)