Repository navigation
fix(menu): write the block's overrides whole, and leave ids set elsewhere - #14
Merged
Merged
Conversation
…here The Omarchy menu fills a user entry's missing fields before merging it over its own (no label: the id, no icon: none), so the block's entries that only change action or when showed their bare id: "install", "update.omarchy", "update.channel", the security entries. The block also came after omarchy-setup's whole FIDO2 and fingerprint entries and replaced them. omarchy-mu-menu-sync now writes each override of an Omarchy entry whole: the stock entry, its label in the menu's language (the English one kept as a search term), then the block's fields. An id the file already sets outside the block is left to that entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Omarchy menu fills a user entry's missing fields before merging it over its own. An entry with no label gets its id as the label, and one with no icon gets none. The block's entries that only change
actionorwhentherefore showed their bare id and no icon: Install, Update › Omarchy, Update › Channel, Remove › Fingerprint and the admin-gated security and removal entries. The block also came after omarchy-setup's whole FIDO2 and fingerprint entries with the same ids. Being later, it replaced them, so those showed their ids too.omarchy-mu-menu-syncwrites each override of an Omarchy entry whole. It starts from the stock entry (default/omarchy/omarchy-menu.jsonc), takes its label, title and description in the menu's language (default/i18n/<code>/menu.json), and keeps the English label insearchTerms, as the menu does for its own rows. The block's fields go on top. Entries with their own label (Switch User, Users…) are unchanged.OMU_UPSTREAM_MENUandOMU_UPSTREAM_I18Npoint the script at other Omarchy files, for tests.Test plan
tests/sh/menu-sync.test.sh: 11 passed. The two new tests cover overrides written whole in pt-BR and in English, and ids set outside the block being left alone (idempotent).just test🤖 Generated with Claude Code