Skip to content

fix(menu): write the block's overrides whole, and leave ids set elsewhere - #14

Merged
lbssousa merged 1 commit into
mainfrom
fix/menu-complete-entries
Nov 7, 2026
Merged

lbssousa merged 1 commit into
mainfrom
fix/menu-complete-entries

Conversation

@lbssousa

@lbssousa lbssousa commented Nov 7, 2026

Copy link
Copy Markdown
Owner

Summary

The Omarchy menu fills a user entry's missing fields before merging it over its own. An entry with no label gets its id as the label, and one with no icon gets none. The block's entries that only change action or when therefore showed their bare id and no icon: Install, Update › Omarchy, Update › Channel, Remove › Fingerprint and the admin-gated security and removal entries. The block also came after omarchy-setup's whole FIDO2 and fingerprint entries with the same ids. Being later, it replaced them, so those showed their ids too.

  • omarchy-mu-menu-sync writes each override of an Omarchy entry whole. It starts from the stock entry (default/omarchy/omarchy-menu.jsonc), takes its label, title and description in the menu's language (default/i18n/<code>/menu.json), and keeps the English label in searchTerms, as the menu does for its own rows. The block's fields go on top. Entries with their own label (Switch User, Users…) are unchanged.
  • An id the file already sets outside the block, by hand or by omarchy-setup's overrides, is left to that entry instead of being replaced.
  • OMU_UPSTREAM_MENU and OMU_UPSTREAM_I18N point the script at other Omarchy files, for tests.
  • CHANGELOG (Unreleased).

Test plan

  • tests/sh/menu-sync.test.sh: 11 passed. The two new tests cover overrides written whole in pt-BR and in English, and ids set outside the block being left alone (idempotent).
  • just test
  • Ran on a real pt-BR menu: Segurança lists Impressão digital, Chave de segurança, SSHD, Docker sem sudo and Sudo sem senha, and Atualizar lists Omarchy and Canal, all with their icons.

🤖 Generated with Claude Code

…here

The Omarchy menu fills a user entry's missing fields before merging it
over its own (no label: the id, no icon: none), so the block's entries
that only change action or when showed their bare id: "install",
"update.omarchy", "update.channel", the security entries. The block also
came after omarchy-setup's whole FIDO2 and fingerprint entries and
replaced them.

omarchy-mu-menu-sync now writes each override of an Omarchy entry
whole: the stock entry, its label in the menu's language (the English one
kept as a search term), then the block's fields. An id the file already
sets outside the block is left to that entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lbssousa
lbssousa merged commit 8f721e9 into main Nov 7, 2026
1 check passed
@lbssousa lbssousa mentioned this pull request Nov 7, 2026
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant