Repository navigation
fix(login): keep a disk a token opens from logging its only account in - #9
Merged
Merged
Conversation
With one account on an encrypted disk, omarchy-mu-login-select logged it in whatever opened the disk. A TPM2 token opens it with nobody typing a password, so the machine started into an open desktop. A token in the LUKS header (TPM2, FIDO2, clevis), or a header that can't be read, now asks for the same record of a typed password's slot that several accounts need, and the login screen shows without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With one account on an encrypted disk,
omarchy-mu-login-selectlogged it in whatever opened the disk. A TPM2 token opens the disk with nobody typing a password, so the machine started into an open desktop.A disk whose LUKS header has a token (TPM2, FIDO2, clevis) now needs the same thing several accounts already did: the boot image's record of the key slot a typed password opened, mapped to that account. Without it, the login screen shows. A header that can't be read counts as having a token.
With
sd-encrypt, which TPM2 unlocking needs, the boot image'scryptsetupwrapper isn't there, so such a machine always shows the login screen after boot, even when the password was typed at the fallback prompt.Testing
just testpasses.shellcheckisn't installed here, so CI covers it.systemd-cryptenrolland clevis write. Without the fix, the one-account test fails.🤖 Generated with Claude Code