fix: respect infoview display settings for goals in messages (#734)#789
Open
MohammadYusif wants to merge 1 commit into
Open
fix: respect infoview display settings for goals in messages (#734)#789MohammadYusif wants to merge 1 commit into
MohammadYusif wants to merge 1 commit into
Conversation
…ver#734) Goals embedded in messages (e.g. the "unsolved goals" diagnostic) were rendered by InteractiveMessageTag in traceExplorer.tsx with a hardcoded settings object, so user infoview settings such as "Display target before assumptions" (reverseTacticState) were ignored for these goals. Derive the settings from ConfigContext via the existing goalSettingsStateOfConfig helper (now exported from goals.tsx), so message-embedded goals respect the same display settings as the main goal panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InteractiveMessageTagintraceExplorer.tsxwith a hardcoded settings object, so user infoview settings such as Display target before assumptions (reverseTacticState) were ignored for these goals.goalSettingsStateOfConfig(config); the message path duplicated a frozen subset, so every display toggle was ignored for message-embedded goals.Changes
lean4-infoview/src/infoview/goals.tsx: export the existinggoalSettingsStateOfConfighelper.lean4-infoview/src/infoview/traceExplorer.tsx: readConfigContextand passgoalSettingsStateOfConfig(config)to<Goal>, replacing the hardcoded settings block so message-embedded goals respect the same display settings as the main goal panel.Fixes #734