Skip to content

fix: respect infoview display settings for goals in messages (#734) #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohammadYusif wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: respect infoview display settings for goals in messages (#734) #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lean4-infoview/src/infoview/goals.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ interface GoalSettingsState {
showLetValue: boolean
}

function goalSettingsStateOfConfig(config: InfoviewConfig): GoalSettingsState {
export function goalSettingsStateOfConfig(config: InfoviewConfig): GoalSettingsState {
return {
reverse: config.reverseTacticState,
hideGoalNames: !config.showGoalNames,
Expand Down
20 changes: 4 additions & 16 deletions lean4-infoview/src/infoview/traceExplorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@

import { HighlightedMsgEmbed, HighlightedTraceEmbed, lazyTraceChildrenToInteractive } from '@leanprover/infoview-api'
import * as React from 'react'
import { Goal } from './goals'
import { ConfigContext } from './contexts'
import { Goal, goalSettingsStateOfConfig } from './goals'
import {
InteractiveCode,
InteractiveTaggedText,
Expand Down Expand Up @@ -117,26 +118,13 @@ function Trace(traceEmbed: HighlightedTraceEmbed) {
function InteractiveMessageTag({
tag: embed,
}: InteractiveTagProps<HighlightedMsgEmbed, HighlightedMsgEmbed>): JSX.Element {
const config = React.useContext(ConfigContext)
if (embed === 'highlighted') {
return <span className="highlighted-text"></span>
}
if ('expr' in embed) return <InteractiveCode fmt={embed.expr} />
else if ('goal' in embed)
return (
<Goal
goal={embed.goal}
settings={{
reverse: false,
hideGoalNames: false,
emphasizeFirstGoal: false,
showType: true,
showInstance: true,
showHiddenAssumption: true,
showLetValue: true,
}}
additionalClassNames=""
/>
)
return <Goal goal={embed.goal} settings={goalSettingsStateOfConfig(config)} additionalClassNames="" />
else if ('widget' in embed)
return <DynamicComponent hash={embed.widget.wi.javascriptHash} props={embed.widget.wi.props} />
else if ('trace' in embed) return <Trace {...embed.trace} />
Expand Down