Update project to Swift 6, Xcode 26.x & >= macOS 15.x#899
Update project to Swift 6, Xcode 26.x & >= macOS 15.x#899sammcj wants to merge 2 commits intoleits:masterfrom
Conversation
dosubot
Bot
added
the
size:L
WalkthroughProject updated for Xcode 26.3 / Swift 6; macOS deployment target raised to 15.6. Sandbox entitlements were removed from the entitlements file and migrated to build settings. Added Simplified Chinese ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sammcj
force-pushed
the
fix_calendar_permissions
branch
from
49b635c to
5bd6e76
Compare
sammcj
force-pushed
the
fix_calendar_permissions
branch
from
5bd6e76 to
c74676f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
MeetingBar.xcodeproj/project.pbxproj (3)
378-378: Project-level deployment target also inconsistent.The project-level configurations (Debug line 378, Release line 443) still have
MACOSX_DEPLOYMENT_TARGET = 12.0, while the MeetingBar target overrides this to 15.6. While target-level settings take precedence, having consistent values at the project level improves clarity and avoids confusion for contributors.Also applies to: 443-443
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@MeetingBar.xcodeproj/project.pbxproj` at line 378, The project-level MACOSX_DEPLOYMENT_TARGET is set to 12.0 in project configurations (Debug/Release) while the MeetingBar target uses 15.6; update the project-level MACOSX_DEPLOYMENT_TARGET entries so they match the MeetingBar target (set both Debug and Release project configuration keys MACOSX_DEPLOYMENT_TARGET to 15.6) to keep project and target deployment targets consistent and avoid confusion.
536-558: Deployment target inconsistency between main app and test target.The MeetingBar app target has
MACOSX_DEPLOYMENT_TARGET = 15.6(lines 479, 513), but the MeetingBarTests target still hasMACOSX_DEPLOYMENT_TARGET = 12.0(lines 536, 558). While tests can technically have a lower deployment target, this inconsistency may cause issues if tests use APIs available only in 15.6+.Consider aligning the test target deployment target with the main app target for consistency.
♻️ Suggested fix
14619A2225EC26DF00F3098F /* Debug */ = { ... - MACOSX_DEPLOYMENT_TARGET = 12.0; + MACOSX_DEPLOYMENT_TARGET = 15.6; ... }; 14619A2325EC26DF00F3098F /* Release */ = { ... - MACOSX_DEPLOYMENT_TARGET = 12.0; + MACOSX_DEPLOYMENT_TARGET = 15.6; ... };🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@MeetingBar.xcodeproj/project.pbxproj` around lines 536 - 558, The MeetingBarTests build configurations (XCBuildConfiguration entries named Debug and Release for MeetingBarTests) set MACOSX_DEPLOYMENT_TARGET = 12.0 which is inconsistent with the main app's MACOSX_DEPLOYMENT_TARGET = 15.6; update the MACOSX_DEPLOYMENT_TARGET values under the MeetingBarTests buildSettings (both Debug and Release configuration blocks where INFOPLIST_FILE = MeetingBarTests/Info.plist or TEST_HOST is set) to 15.6 so the test target matches the main app.
359-359: Hardcoded development team identifier added.
DEVELOPMENT_TEAM = KGH289N6T8has been added to multiple configurations. For an open-source project, contributors typically need to change this to their own team ID. This is common and expected, but worth noting that contributors will need to modify this setting (or useCODE_SIGN_STYLE = Manual) to build locally.Also applies to: 430-430, 529-529, 551-551
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@MeetingBar.xcodeproj/project.pbxproj` at line 359, Remove the hardcoded DEVELOPMENT_TEAM entries and replace them with a non-user-specific configuration: either set CODE_SIGN_STYLE = Manual for the affected build configurations or change DEVELOPMENT_TEAM = KGH289N6T8 to a placeholder reference (e.g., DEVELOPMENT_TEAM = $(DEVELOPMENT_TEAM)) so contributors can supply their own team ID via Xcode build settings or environment; update every occurrence of the DEVELOPMENT_TEAM build setting in the project.pbxproj (and ensure CODE_SIGN_STYLE is set to Manual where appropriate) to avoid forcing a specific Apple team ID on contributors.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@MeetingBar.xcodeproj/project.pbxproj`:
- Line 378: The project-level MACOSX_DEPLOYMENT_TARGET is set to 12.0 in project
configurations (Debug/Release) while the MeetingBar target uses 15.6; update the
project-level MACOSX_DEPLOYMENT_TARGET entries so they match the MeetingBar
target (set both Debug and Release project configuration keys
MACOSX_DEPLOYMENT_TARGET to 15.6) to keep project and target deployment targets
consistent and avoid confusion.
- Around line 536-558: The MeetingBarTests build configurations
(XCBuildConfiguration entries named Debug and Release for MeetingBarTests) set
MACOSX_DEPLOYMENT_TARGET = 12.0 which is inconsistent with the main app's
MACOSX_DEPLOYMENT_TARGET = 15.6; update the MACOSX_DEPLOYMENT_TARGET values
under the MeetingBarTests buildSettings (both Debug and Release configuration
blocks where INFOPLIST_FILE = MeetingBarTests/Info.plist or TEST_HOST is set) to
15.6 so the test target matches the main app.
- Line 359: Remove the hardcoded DEVELOPMENT_TEAM entries and replace them with
a non-user-specific configuration: either set CODE_SIGN_STYLE = Manual for the
affected build configurations or change DEVELOPMENT_TEAM = KGH289N6T8 to a
placeholder reference (e.g., DEVELOPMENT_TEAM = $(DEVELOPMENT_TEAM)) so
contributors can supply their own team ID via Xcode build settings or
environment; update every occurrence of the DEVELOPMENT_TEAM build setting in
the project.pbxproj (and ensure CODE_SIGN_STYLE is set to Manual where
appropriate) to avoid forcing a specific Apple team ID on contributors.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 0aa6e4e7-b27f-4dd2-ac9e-6563954b0a92
📒 Files selected for processing (6)
CHANGELOG.mdMeetingBar.xcodeproj/project.pbxprojMeetingBar.xcodeproj/xcshareddata/xcschemes/MeetingBar.xcschemeMeetingBar/Info.plistMeetingBar/MeetingBar.entitlementsMeetingBar/UI/Views/Changelog/Changelog.swift
💤 Files with no reviewable changes (1)
- MeetingBar/MeetingBar.entitlements
|
@coderabbitai comments addressed, tests passing. FYI @leits |
|
Tip For best results, initiate chat on the files or code changes.
If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
===========================================
+ Coverage 26.30% 36.38% +10.08%
===========================================
Files 36 48 +12
Lines 5645 5106 -539
Branches 2210 1735 -475
===========================================
+ Hits 1485 1858 +373
+ Misses 4103 3191 -912
Partials 57 57 ☔ View full report in Codecov by Sentry. |
|
@leits FYI |
sammcj
changed the title
1 participant
Status
READY
Description
ENABLE_APP_SANDBOX,ENABLE_OUTGOING_NETWORK_CONNECTIONS,ENABLE_RESOURCE_ACCESS_CALENDARS,ENABLE_USER_SELECTED_FILES)Notes
Fixes #898
Checklist
Steps to Test or Reproduce
Summary by CodeRabbit