Skip to content

ffc.h: Remove clang ifdefs#16

Merged
lemire merged 1 commit into
lemire:masterfrom
kolemannix:ffc_all_compilers
Mar 4, 2026
Merged

ffc.h: Remove clang ifdefs#16
lemire merged 1 commit into
lemire:masterfrom
kolemannix:ffc_all_compilers

Conversation

@kolemannix

Copy link
Copy Markdown
Contributor

Testing if this works; I compiled locally with gcc and it worked.

cmake -B build \
  -DCMAKE_C_COMPILER=gcc \
  -DCMAKE_CXX_COMPILER=g++ \
  -DCMAKE_BUILD_TYPE=Release
...

@kolemannix kolemannix changed the title Remove clang ifdefs ffc.h: Remove clang ifdefs Mar 4, 2026
@lemire

lemire commented Mar 4, 2026

Copy link
Copy Markdown
Owner

Running tests. Looking good so far.

@kolemannix

Copy link
Copy Markdown
Contributor Author

GCC success! I think the msvc fails are just the VLA issue again; the latest main should not have that problem. Will CMake pull from github fresh on every run?

@lemire

lemire commented Mar 4, 2026

Copy link
Copy Markdown
Owner

I will pull out my trusty Windows laptop.

Will CMake pull from github fresh on every run?

Well. There is no disk buffer anywhere. It has no choice to load it up fresh from the network.

@lemire

lemire commented Mar 4, 2026

Copy link
Copy Markdown
Owner

I will merge and review Visual Studio separately.

@lemire
lemire merged commit fb5fe4c into lemire:master Mar 4, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants