Skip to content

ffc.h: Remove clang ifdefs #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 1 commit into from
Mar 4, 2026
Merged

ffc.h: Remove clang ifdefs #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions benchmarks/benchmark.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@
#include "absl/strings/numbers.h"
#endif
#include "fast_float/fast_float.h"
#ifdef __clang__
extern "C" {
#include "ffc.h"
}
#endif
#ifdef ENABLE_RYU
#include "ryu_parse.h"
#endif
Expand Down Expand Up @@ -178,7 +176,6 @@ double findmax_absl_from_chars(std::vector<std::string> &s, bool expect_error) {
}
#endif

#ifdef __clang__
double findmax_ffc(std::vector<std::string> &s, bool expect_error) {
double answer = 0;
double x = 0;
Expand All @@ -191,7 +188,6 @@ double findmax_ffc(std::vector<std::string> &s, bool expect_error) {
}
return answer;
}
#endif

#ifdef USING_COUNTERS
template <class T, class CharT>
Expand Down Expand Up @@ -350,9 +346,7 @@ void process(std::vector<std::string> &lines, size_t volume, bool expect_error)
pretty_print(volume, lines.size(), "abseil", time_it_ns(lines, findmax_absl_from_chars, repeat, expect_error));
#endif
pretty_print(volume, lines.size(), "fastfloat", time_it_ns(lines, findmax_fastfloat<char>, repeat, expect_error));
#ifdef __clang__
pretty_print(volume, lines.size(), "ffc", time_it_ns(lines, findmax_ffc, repeat, expect_error));
#endif
#ifdef FROM_CHARS_AVAILABLE_MAYBE
pretty_print(volume, lines.size(), "from_chars", time_it_ns(lines, findmax_from_chars, repeat, expect_error));
#endif
Expand Down
6 changes: 0 additions & 6 deletions benchmarks/benchmark32.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@
#include "absl/strings/numbers.h"
#endif
#include "fast_float/fast_float.h"
#ifdef __clang__
extern "C" {
#include "ffc.h"
}
#endif
#ifdef ENABLE_RYU
#include "ryu_parse.h"
#endif
Expand Down Expand Up @@ -158,7 +156,6 @@ double findmax_absl_from_chars(std::vector<std::string> &s) {
}
#endif

#ifdef __clang__
double findmax_ffc(std::vector<std::string> &s) {
double answer = 0;
float x = 0;
Expand All @@ -171,7 +168,6 @@ double findmax_ffc(std::vector<std::string> &s) {
}
return answer;
}
#endif

#ifdef USING_COUNTERS
template <class T, class CharT>
Expand Down Expand Up @@ -316,9 +312,7 @@ void process(std::vector<std::string> &lines, size_t volume) {
pretty_print(volume, lines.size(), "abseil", time_it_ns(lines, findmax_absl_from_chars, repeat));
#endif
pretty_print(volume, lines.size(), "fastfloat", time_it_ns(lines, findmax_fastfloat<char>, repeat));
#ifdef __clang__
pretty_print(volume, lines.size(), "ffc", time_it_ns(lines, findmax_ffc, repeat));
#endif
#ifdef FROM_CHARS_AVAILABLE_MAYBE
pretty_print(volume, lines.size(), "from_chars", time_it_ns(lines, findmax_from_chars, repeat));
#endif
Expand Down
Loading