Skip to content

Repin install-whitaker to 5a99aed7 (installer 0.2.11) - #241

Merged
leynos merged 1 commit into
mainfrom
whitaker-5a99aed7
Oct 30, 2026
Merged

leynos merged 1 commit into
mainfrom
whitaker-5a99aed7

Conversation

@leynos

@leynos leynos commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Repins install-whitaker to shared-actions 5a99aed78ce68dcebd3052b75c31e6f173162b1e (leynos/shared-actions#651, approved as a QG-002 root by leynos/concordat#331). That revision defaults to whitaker-installer 0.2.11, which builds the Dylint driver from a verified Clippy snapshot instead of cloning Clippy's deleted master branch, so cold lint lanes work again. Part of DF12-89.

  • Pin only, with no trailing version comment.
  • A cache-restored driver rebuilds once (about a minute); that is expected.

Summary by Sourcery

Repin the Whitaker installer action to restore reliable CI linting with installer 0.2.11.

Bug Fixes:

  • Restore cold CI lint lanes by repinning the Whitaker installer action to a revision that uses the current verified Clippy snapshot.

CI:

  • Update the Whitaker Dylint suite action reference in CI.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T05:08:28.641891Z 4fcff78 PR opened
🔒 Security Review ✅ Completed 2026-10-30T05:09:05.216278Z 4fcff78 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 69524de8-e814-4bca-b144-ef8f84e45088
Commits

Reviewing files that changed from the base of the PR and between 43b11a1 and 4fcff78.

Files selected for processing: 1
  • .github/workflows/ci.yml
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Repin install-whitaker in .github/workflows/ci.yml to shared-actions revision 5a99aed78ce68dcebd3052b75c31e6f173162b1e. This revision uses installer 0.2.11, which builds the Dylint driver from a verified Clippy snapshot. It avoids cloning Clippy’s deleted master branch and restores cold lint lanes. Part of DF12-89.

Walkthrough

The CI workflow now pins the Whitaker Dylint installer action to commit 5a99aed78ce68dcebd3052b75c31e6f173162b1e instead of the previous commit.

Changes

CI installer pin update

Layer / File(s) Summary
Update the installer action pin
.github/workflows/ci.yml
The workflow uses the new commit for the Whitaker Dylint installer action.

Possibly related issues

Possibly related PRs

Priority: Normal

Change: Bug fix

Merge Risk: Minimal · up to 4fcff

The installer pin update is ready to merge with no identified production or CI risk introduced by this change.

Pre-merge checks: Passed 14 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Developer Documentation Warning The pull request changes CI tooling by repinning install-whitaker in .github/workflows/ci.yml:46 from 8e6a325... to 5a99aed.... The pull request changes no documentation, and `docs/developers-… Add a section to docs/developers-guide.md that documents the Whitaker CI installer pin, the default installer version 0.2.11, the RUSTUP_TOOLCHAIN: stable requirement, and the make lint integration. State that the action is pinned b…
Passed Passed checks: 14 passed
Check name Status Explanation
Title check Passed The title names the change: repinning install-whitaker to commit 5a99aed7 (installer 0.2.11). It matches the main change in the changeset, which updates one pinned commit in the CI workflow. The title…
Description check Passed The description states the purpose of the change. It repins install-whitaker to shared-actions revision 5a99aed7 and explains that this revision defaults to whitaker-installer 0.2.11. It also explains…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Testing (Overall) Passed PASS. The pull request changes only the pinned revision of the third-party install-whitaker GitHub Action in .github/workflows/ci.yml (line 46). It adds no repository functionality or local behavi…
User-Facing Documentation Passed Pass this check. The PR changes only the pinned install-whitaker action revision in .github/workflows/ci.yml. This updates CI tooling and does not introduce or change user-facing functionality, be…
Module-Level Documentation Passed Pass. The pull request changes only the install-whitaker action pin in .github/workflows/ci.yml. It introduces or changes no module, so it does not create a module-level documentation failure.
Testing (Unit And Behavioural) Passed PASS. The pull request changes one GitHub Actions commit pin only. It does not change local application behaviour, so no unit-test addition is required. The existing CI boundary installs `install-whit…
Testing (Property / Proof) Passed The pull request changes one GitHub Actions reference in .github/workflows/ci.yml. It does not introduce an invariant over inputs, states, orderings, or transitions, and it introduces no lemma or pr…
Testing (Compile-Time / Ui) Passed Pass the testing check. The pull request changes only the pinned install-whitaker GitHub Action reference in .github/workflows/ci.yml; it adds no Rust or TypeScript compile-time behaviour and no t…
Unit Architecture Passed Pass. The pull request changes only the pinned revision of the existing Install Whitaker Dylint suite workflow command in .github/workflows/ci.yml (line 46). It does not add or alter query paths, …
Domain Architecture Passed Pass. The pull request changes only the GitHub Actions pin for install-whitaker in .github/workflows/ci.yml (line 46). It does not change domain logic, domain entities, commands, repositories, ada…
Observability Passed PASS — The pull request changes one GitHub Actions pin only. It does not change production code or service behaviour. The workflow retains a named Install Whitaker Dylint suite step and a separate `…
Full details: Title check

Explanation

The title names the change: repinning install-whitaker to commit 5a99aed7 (installer 0.2.11). It matches the main change in the changeset, which updates one pinned commit in the CI workflow. The title does not reference a roadmap item or issue number, and the requirements only call for those when the PR implements a roadmap task or fixes a referenced issue. The description cites DF12-89, but that is a tracker reference, not a roadmap item number or GitHub issue, so no number is required. The title meets the stated requirements.

Full details: Description check

Explanation

The description states the purpose of the change. It repins install-whitaker to shared-actions revision 5a99aed7 and explains that this revision defaults to whitaker-installer 0.2.11. It also explains the effect on cold lint lanes and notes that a cache-restored driver rebuilds once. This matches the single-line change in .github/workflows/ci.yml.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Testing (Overall)

Explanation

PASS. The pull request changes only the pinned revision of the third-party install-whitaker GitHub Action in .github/workflows/ci.yml (line 46). It adds no repository functionality or local behavioural logic. The check explicitly does not require tests to verify that a third-party tool or library works as advertised. Existing CI still runs make lint after installation, but no new substantive local test is required for this pin-only change.

Full details: User-Facing Documentation

Explanation

Pass this check. The PR changes only the pinned install-whitaker action revision in .github/workflows/ci.yml. This updates CI tooling and does not introduce or change user-facing functionality, behaviour, or usage. No docs/users-guide.md update is required.

Full details: Testing (Unit And Behavioural)

Explanation

PASS. The pull request changes one GitHub Actions commit pin only. It does not change local application behaviour, so no unit-test addition is required. The existing CI boundary installs install-whitaker and then runs make lint; the workflow also runs workflow contract tests. These checks exercise the affected integration path without adding tests that only inspect an internal seam.

Full details: Testing (Property / Proof)

Explanation

The pull request changes one GitHub Actions reference in .github/workflows/ci.yml. It does not introduce an invariant over inputs, states, orderings, or transitions, and it introduces no lemma or proof assumption. No property test or exhaustive proof is required by this check.

Full details: Testing (Compile-Time / Ui)

Explanation

Pass the testing check. The pull request changes only the pinned install-whitaker GitHub Action reference in .github/workflows/ci.yml; it adds no Rust or TypeScript compile-time behaviour and no text, structured, or UI-adjacent output. Trybuild or snapshot tests are therefore not applicable.

Full details: Unit Architecture

Explanation

Pass. The pull request changes only the pinned revision of the existing Install Whitaker Dylint suite workflow command in .github/workflows/ci.yml (line 46). It does not add or alter query paths, application units, dependencies, state handling, or tests. The installer remains an explicit command step, and RUSTUP_TOOLCHAIN: stable remains visible at the workflow boundary.

Full details: Domain Architecture

Explanation

Pass. The pull request changes only the GitHub Actions pin for install-whitaker in .github/workflows/ci.yml (line 46). It does not change domain logic, domain entities, commands, repositories, adapters, or transport and persistence boundaries.

Full details: Observability

Explanation

PASS — The pull request changes one GitHub Actions pin only. It does not change production code or service behaviour. The workflow retains a named Install Whitaker Dylint suite step and a separate Lint step, which provide clear CI log and failure boundaries. No new production metric, trace, or alert is required for this CI dependency repin.

Full details: Developer Documentation

Explanation

The pull request changes CI tooling by repinning install-whitaker in .github/workflows/ci.yml:46 from 8e6a325... to 5a99aed.... The pull request changes no documentation, and docs/developers-guide.md documents make lint but does not document Whitaker provisioning or this installer requirement. This violates the developer documentation requirement for changed tooling.

Resolution

Add a section to docs/developers-guide.md that documents the Whitaker CI installer pin, the default installer version 0.2.11, the RUSTUP_TOOLCHAIN: stable requirement, and the make lint integration. State that the action is pinned by commit and must be updated through a reviewed pin change.

A pinned action shifts its place
One commit now sets the pace
CI follows the updated trail
The workflow holds the newer detail
One small change completes the tale

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Sorry @leynos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 6 days and 16 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

sourcery-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CI Whitaker installer pin to shared-actions commit 5a99aed7, selecting installer 0.2.11 so Dylint can build from a verified Clippy snapshot instead of the deleted Clippy master branch; a cache-restored driver rebuild is expected.

File-Level Changes

Change Details Files
Repin the Whitaker installer action to a shared-actions revision that uses whitaker-installer 0.2.11 and restores cold lint-lane compatibility.
  • Update the action reference to commit 5a99aed78ce68dcebd3052b75c31e6f173162b1e.
  • Rely on the installer’s verified Clippy snapshot when rebuilding the Dylint driver.
  • Keep the change limited to the action pin, without a trailing version comment.
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant