Repository navigation
Repin install-whitaker to 5a99aed7 (whitaker-installer 0.2.11) - #670
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe CI lint workflow now pins the Whitaker installer action to shared-actions commit 5a99aed7, avoiding cold driver-build failures caused by upstream Dylint cloning the removed Clippy master branch; reviewers should verify the lint lane is green and inspect its Whitaker diagnostics. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Summary
WalkthroughThe CI workflow now pins the Whitaker installer to shared-actions revision ChangesWhitaker CI installer pin
Possibly related issues
Possibly related PRs
Priority: Change: Bug fix Merge Risk:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Developer Documentation |  |
The pull request changes the Whitaker CI tooling pin from shared-actions revision 013346cc to 5a99aed7 and that action defaults to whitaker-installer 0.2.11 (the linked leynos/shared-actions… |
Update docs/developers-guide.md in the Whitaker tool-installation section. State that the pinned action revision uses whitaker-installer 0.2.11, provisions the verified Clippy snapshot for the Dylint driver, and can rebuild the cached… |
-
Check name Status Explanation Title check The title clearly describes the main change: repinning the Whitaker installation action to revision 5a99aed7. No roadmap item or GitHub issue number requires inclusion in the title. Description check The description directly explains the Whitaker action repin, its purpose, scope, and validation criteria. It is related to the changeset. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Testing (Overall) PASS. The pull request changes one uses:reference in.github/workflows/ci.yml; it does not add repository functionality or local Whitaker logic. The referenced action is a third-party installer. …User-Facing Documentation The pull request changes only the pinned install-whitakerGitHub Actions reference in.github/workflows/ci.yml(one line). It changes CI tool provisioning and introduces no user-facing functionali…Module-Level Documentation Pass the check. The pull request changes only the Whitaker action revision in .github/workflows/ci.yml; it adds no module or module code. Therefore, it introduces no module-level documentation failu…Testing (Unit And Behavioural) PASS — the pull request changes only the SHA of the existing Whitaker installer step in .github/workflows/ci.yml(base013346cc…to head5a99aed7…). It adds no local application behaviour that n…Testing (Property / Proof) Pass this check. The pull request changes only the Whitaker action pin in .github/workflows/ci.yml; it introduces no code invariant, range of inputs, state transition, lemma, or proof assumption tha…Testing (Compile-Time / Ui) PASS: The pull request changes only the pinned install-whitakeraction reference in.github/workflows/ci.yml. It introduces no Rust or TypeScript compile-time behaviour and no text, structured, or…Unit Architecture Accept this change. The pull request changes only the pinned revision on the existing Install Whitakerworkflow step. It does not add queries, commands, dependencies, state mutation, or new responsi…Domain Architecture The pull request changes only .github/workflows/ci.yml. It repins theinstall-whitakerGitHub Action and adds a version comment. It does not change domain logic, adapters, persistence, transport, …Observability Pass this check. The pull request changes one CI-only install-whitakerSHA in.github/workflows/ci.yml(line 326); it does not change a production service or request path. Thelint-testjob expo…Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Full details: Testing (Overall)
-
Explanation
PASS. The pull request changes one
uses:reference in.github/workflows/ci.yml; it does not add repository functionality or local Whitaker logic. The referenced action is a third-party installer. The check therefore does not require a new test for the installer implementation. Existing CI still runsmake lint, whoselint-whitakertarget invokes Whitaker across the Rust workspace (Makefile:536-542).
Full details: User-Facing Documentation
-
Explanation
The pull request changes only the pinned
install-whitakerGitHub Actions reference in.github/workflows/ci.yml(one line). It changes CI tool provisioning and introduces no user-facing functionality or behaviour. No update todocs/users-guide.mdis required.
Full details: Module-Level Documentation
-
Explanation
Pass the check. The pull request changes only the Whitaker action revision in
.github/workflows/ci.yml; it adds no module or module code. Therefore, it introduces no module-level documentation failure.
Full details: Testing (Unit And Behavioural)
-
Explanation
PASS — the pull request changes only the SHA of the existing Whitaker installer step in
.github/workflows/ci.yml(base013346cc…to head5a99aed7…). It adds no local application behaviour that needs unit tests. The existinglint-testworkflow exercises the functional boundary: it installs Whitaker, then runsmake lint;lint-whitakerinvokes the installedwhitakerwrapper for the Rust workspace. The referenced shared action also has behavioural coverage for verified installation, cache reuse, and installer failure paths atleynos/shared-actionscommit5a99aed78ce68dcebd3052b75c31e6f173162b1e(.github/actions/install-whitaker/tests/test_install_whitaker_install.py:90-133andtests/test_install_whitaker_run_step.py:175-214). No additional local unit test would provide meaningful coverage for this pin-only change.
Full details: Testing (Property / Proof)
-
Explanation
Pass this check. The pull request changes only the Whitaker action pin in
.github/workflows/ci.yml; it introduces no code invariant, range of inputs, state transition, lemma, or proof assumption that requires property testing or exhaustive proof.
Full details: Testing (Compile-Time / Ui)
-
Explanation
PASS: The pull request changes only the pinned
install-whitakeraction reference in.github/workflows/ci.yml. It introduces no Rust or TypeScript compile-time behaviour and no text, structured, or UI output requiring trybuild or snapshot tests.
Full details: Unit Architecture
-
Explanation
Accept this change. The pull request changes only the pinned revision on the existing
Install Whitakerworkflow step. It does not add queries, commands, dependencies, state mutation, or new responsibilities. The existing action contract and Whitaker references remain unchanged.
Full details: Domain Architecture
-
Explanation
The pull request changes only
.github/workflows/ci.yml. It repins theinstall-whitakerGitHub Action and adds a version comment. It does not change domain logic, adapters, persistence, transport, or infrastructure code boundaries. The Domain Architecture check passes.
Full details: Observability
-
Explanation
Pass this check. The pull request changes one CI-only
install-whitakerSHA in.github/workflows/ci.yml(line 326); it does not change a production service or request path. Thelint-testjob exposes installation and lint failures through named failed steps (lines 325-326 and 410-411), and it records job summaries for compiler-cache results (lines 428-440). The pinned shared action also emits bounded cache, transfer, digest, source-selection, and failure diagnostics to the GitHub step summary at commit5a99aed78ce68dcebd3052b75c31e6f173162b1e(.github/actions/install-whitaker/action.yml, lines 236-247 and 920-1021). No additional production metrics, traces, or alerts are required.
-
Full details: Developer Documentation
-
Explanation
The pull request changes the Whitaker CI tooling pin from shared-actions revision
013346ccto5a99aed7and that action defaults towhitaker-installer0.2.11(the linkedleynos/shared-actionsaction manifest at commit5a99aed78ce68dcebd3052b75c31e6f173162b1e,.github/actions/install-whitaker/action.yml, lines 5-16). The pull request changes only.github/workflows/ci.yml;docs/developers-guide.mdstill documents only0.2.9 or laterat lines 943-962. It does not document the new0.2.11verified Clippy snapshot bootstrap or its cold-driver-build implication.Resolution
Update
docs/developers-guide.mdin the Whitaker tool-installation section. State that the pinned action revision useswhitaker-installer0.2.11, provisions the verified Clippy snapshot for the Dylint driver, and can rebuild the cached driver once on a cold cache. Keep the action pin and the documented installer version aligned. Add an ADR or design-document update only if this pin represents a broader architectural decision; the current evidence does not require one.
Pin the workflow to the shared revision.
Keep Whitaker’s installer reference aligned.
Let CI call the updated action.
Carry the version through the YAML.
Run the checks with the new pin.
Comment @coderabbitai help to get the list of available commands.
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/ci.yml" line_range="326" />
<code_context>
- name: Install Whitaker
- uses: leynos/shared-actions/.github/actions/install-whitaker@013346ccfd37bd1e02eb430525233f1a4cd942b8
+ uses: leynos/shared-actions/.github/actions/install-whitaker@5a99aed78ce68dcebd3052b75c31e6f173162b1e # shared-actions 5a99aed7 (whitaker-installer 0.2.11)
- name: Validate Mermaid diagrams
</code_context>
<issue_to_address>
**Lint workflow exceeds line limit**
When the lint job runs yamllint, `yamllint` rejects this `uses:` line because its action pin and inline comment exceed the configured 120-character limit, so the lint job fails.
Move the revision comment to a separate line or shorten it so the workflow line stays within 120 characters.
</issue_to_address>|
|
||
| - name: Install Whitaker | ||
| uses: leynos/shared-actions/.github/actions/install-whitaker@013346ccfd37bd1e02eb430525233f1a4cd942b8 | ||
| uses: leynos/shared-actions/.github/actions/install-whitaker@5a99aed78ce68dcebd3052b75c31e6f173162b1e # shared-actions 5a99aed7 (whitaker-installer 0.2.11) |
There was a problem hiding this comment.
🔴 Critical · Lint workflow exceeds line limit
When the lint job runs yamllint, yamllint rejects this uses: line because its action pin and inline comment exceed the configured 120-character limit, so the lint job fails.
Move the revision comment to a separate line or shorten it so the workflow line stays within 120 characters.
Prompt for AI agents
In `.github/workflows/ci.yml` at line 326:
**Lint workflow exceeds line limit**
When the lint job runs yamllint, `yamllint` rejects this `uses:` line because its action pin and inline comment exceed the configured 120-character limit, so the lint job fails.
Move the revision comment to a separate line or shorten it so the workflow line stays within 120 characters.
Part of DF12-89
Repins
leynos/shared-actions/.github/actions/install-whitakerto5a99aed78ce68dcebd3052b75c31e6f173162b1e(shared-actions #651, approved as a root by concordat QG-002, leynos/concordat#331). The action then defaults to whitaker-installer 0.2.11, which builds the Dylint driver from a verified Clippy snapshot: upstream Dylint 6.0.1 clones Clippy'smaster, which no longer exists, so every cold Whitaker driver build fails.Pin-only: the single
uses:line(s) change; no other file.Other Whitaker paths
No bare
cargo dylint,cargo binstall whitakeror hand-rolled installer outside the action and thewhitakerwrapper.Notes
A cache-restored driver rebuilds once (about a minute); that is expected. Gate: CI green on the lint lane at the head, with the lint job's log read for Whitaker's diagnostics.
Summary by Sourcery
Restore reliable Whitaker lint setup by updating the CI installation action to the approved revision.
Bug Fixes:
CI: