Skip to content

Refresh generated typos.toml from the pinned builder - #1062

Merged
leynos merged 1 commit into
mainfrom
refresh-generated-typos-toml
Nov 1, 2026
Merged

leynos merged 1 commit into
mainfrom
refresh-generated-typos-toml

Conversation

@leynos

@leynos leynos commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

Summary

make spelling regenerates typos.toml from typos-config-builder v0.1.3. That tag now emits a tokio attribute exemption and drops the bare flavor = accept entry, so every branch based on main starts with a dirty typos.toml after running the spelling gate. Commit the regenerated file once so feature branches inherit a clean tree.

Validation

  • make spelling on this branch reports current: typos.toml with no further diff.
  • The change is generated output only; no rules are hand-edited.

References

🤖 Generated with Claude Code

Summary by Sourcery

Enhancements:

  • Refresh the generated spelling configuration to match typos-config-builder v0.1.3, including Tokio attribute exemptions and removal of the obsolete bare flavor entry.

The typos-config-builder v0.1.3 tag now emits a tokio attribute
exemption pattern and no longer needs the bare 'flavor = ' accept
entry. Regenerating with make spelling on main produces this exact
change, so every branch otherwise starts dirty. Commit the generated
file once on main and let feature branches inherit it.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Sorry @leynos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 5 days and 11 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-31T10:53:18.678236Z
We couldn’t complete this review. Comment @codex review to try again.
b4fd721 PR opened
🔒 Security Review ⚠️ Failed 2026-10-31T10:53:27.020367Z
We couldn’t complete this review. Comment @codex security review to try again.
b4fd721 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • typos.toml is excluded by !typos.toml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: d1d64d66-4981-4ef4-83fc-794fa6261842

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

@sourcery-ai

sourcery-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This generated-output-only update refreshes typos.toml to the v0.1.3 builder output, preventing make spelling from leaving repository drift and narrowing flavor exemptions to Tokio attributes.

File-Level Changes

Change Details Files
Regenerated the spelling configuration with typos-config-builder v0.1.3 so the committed output matches the pinned builder.
  • Added regex exemptions for Tokio main/test attributes with supported argument combinations, including local runtime flavor.
  • Removed the broad bare flavor = ignore entry now superseded by the generated Tokio-specific rules.
typos.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

leynos pushed a commit that referenced this pull request Oct 31, 2026
The pinned typos-config-builder generator now emits a tokio attribute
ignore pattern and drops the obsolete 'flavor = ' ignore. Make spelling
regenerates this file on every run, so leaving it uncommitted keeps the
worktree permanently dirty.

The same regeneration is isolated in PR #1062; committing the identical
generated content here stops the drift from masking real worktree state.

Co-Authored-By: Claude Code <noreply@anthropic.com>
leynos pushed a commit that referenced this pull request Oct 31, 2026
The pinned typos-config-builder generator now emits a tokio attribute
ignore pattern and drops the obsolete 'flavor = ' ignore. Make spelling
regenerates this file on every run, so leaving it uncommitted keeps the
worktree permanently dirty.

The same regeneration is isolated in PR #1062; committing the identical
generated content here stops the drift from masking real worktree state.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@leynos
leynos merged commit 9bfb3e1 into main Nov 1, 2026
23 checks passed
@leynos
leynos deleted the refresh-generated-typos-toml branch November 1, 2026 01:36
leynos added a commit that referenced this pull request Nov 1, 2026
The typos-config-builder v0.1.3 tag now emits a tokio attribute
exemption pattern and no longer needs the bare 'flavor = ' accept
entry. Regenerating with make spelling on main produces this exact
change, so every branch otherwise starts dirty. Commit the generated
file once on main and let feature branches inherit it.

Co-authored-by: leynos <leynos@rohga>
Co-authored-by: Claude Code <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant