fix(models): guard unknown display-name receipt recovery - #3902
Conversation
Defer item-bound thinking emission until its envelope can place redacted blocks first. Preserve budget enforcement and live text/tool output. Refs #3719; replay/cache acceptance remains open. Co-authored-by: lidge-jun <243035832+lidge-jun@users.noreply.github.com>
Co-authored-by: lidge-jun <243035832+lidge-jun@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Verification
fe9460372597061f572beee6c325009fef618c42. Cross-platform CI run 34120761219. PASS under the explicit per-chain acceptance policy: all 16 required jobs completed successfully: Linux 4, macOS 2, gates, API usage, storage, all keyring/npm jobs, and Docker. Excluded Windows shards/macOS control are still running and are not part of this verdict.93d860ef9. Reviewed unknown-receipt guards, read-only retry, focus and confirmed-write editing. Scoped implementation is unchanged by subsequent ancestry rebases.Manual dependent chain
c35b5a6e504a4513ad59957f5c81b7db45f8bec6c5fb7e3332432c6546bffa9990bce5b971653139c44c6de87389a95ab798b648659fbc0838af170b5669413794ca54388782f6758171a81a2d1b361efe9460372597061f572beee6c325009fef618c42Ordinary dependent PRs only; native stack membership checked separately, no native registration. Main task alone performs maintainer integration under MAINTAINERS.md; this is not self-approval. Before integration, refresh dev and prove expected cumulative tree equals the tested top tree. No merge performed by this lane.
Dashboard screenshot
Unmodified CI dashboard artifact, source
fe9460372597061f572beee6c325009fef618c42, GUI treed37b888016199ab7470993e24dde1c14b3296d5e. Synthetic in-memory API fixtures; desktop1440x963, interactions and screenshots inspected. Remote tests separately verify actual API/storage behavior.Checklist
Maintainer integration decision (MAINTAINERS.md, dev-only admin integration): @lidge-jun integrates lane D's manual chain (#3877 → #3902 → #3903 → #3904 → #3905) into
devbottom-up. Chain-top evidence at headfe9460372: Cross-platform CI run 34120761219 — Linux test 1/4–4/4, macOS 1/2, 2/2, gates (GUI 1787/0, lint, typecheck, privacy, build), storage policy, api usage, keyring ×3, npm-global ×3, docker smoke = success; Windows shards and macos control deferred to the final release-train head by maintainer policy. Prospective merge tree oforigin/dev@f4a4b468f+ top =ded24302f= tested tree. Independent per-layer reviews PASS; screenshots from this run's dashboard-preview artifact. Local suites NOT RUN. Maintainer integration, not self-approval.