feat(models): edit manual prices and honor explicit zero - #3904
Conversation
Apply base provider overlays to exact configured Codex account identities without widening arbitrary suffix matching. Preserve pricing namespaces, cache invalidation and tier parity. Refs #3817. Co-authored-by: rrmlima <137737127+rrmlima@users.noreply.github.com>
Exact top CI logs on macOS and Windows identified the same privacy-scan fixture rejection. Keep scanner rules and assertions unchanged. Co-authored-by: rrmlima <137737127+rrmlima@users.noreply.github.com>
…ip ci] Expose modelCosts via the Models editor and models price/set-price CLI. Preserve sibling prices, support automatic reset, and treat explicit zero user rates as known-zero display estimates. Refs #3667. Co-authored-by: nordz0r <6949669+nordz0r@users.noreply.github.com>
Address independent review findings on the manual price CLI; preserve HTTP-specific exit codes and project only acknowledged fields. Co-authored-by: nordz0r <6949669+nordz0r@users.noreply.github.com>
Address exact-head GUI lint diagnosis without disabling the rule; initial loading uses initialized state and effects update only after the fetch. Co-authored-by: nordz0r <6949669+nordz0r@users.noreply.github.com>
Exact CI gates diagnosis: keep effect request setup synchronous and update state only from registered fetch settlement callbacks; retain cancellation and identity guards. Co-authored-by: nordz0r <6949669+nordz0r@users.noreply.github.com>
Exact gates log showed the fixture read an unrelated picker alert behind the modal. Keep all expected error text and mutation assertions. Co-authored-by: nordz0r <6949669+nordz0r@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5669413794
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
ocx models price/ocx models set-priceover existing persistedmodelCosts. A manual badge survives reload and reset removes only the selected model override.Closes #3667
Verification
fe9460372597061f572beee6c325009fef618c42. Cross-platform CI run 34120761219. PASS under the explicit per-chain acceptance policy: all 16 required jobs completed successfully: Linux 4, macOS 2, gates, API usage, storage, all keyring/npm jobs, and Docker. Excluded Windows shards/macOS control are still running and are not part of this verdict.e541f499e8ad617b5dd9466e7b7765ef200f4ad9. Astra-high Bohr diagnosed later CI-only lifecycle/fixture corrections; no rules or assertions weakened. Fresh remote GUI tests/lint/build pass.Manual dependent chain
c35b5a6e504a4513ad59957f5c81b7db45f8bec6c5fb7e3332432c6546bffa9990bce5b971653139c44c6de87389a95ab798b648659fbc0838af170b5669413794ca54388782f6758171a81a2d1b361efe9460372597061f572beee6c325009fef618c42Ordinary dependent PRs only; native stack membership checked separately, no native registration. Main task alone performs maintainer integration under MAINTAINERS.md; this is not self-approval. Before integration, refresh dev and prove expected cumulative tree equals the tested top tree. No merge performed by this lane.
Dashboard screenshot
Unmodified CI dashboard artifact, source
fe9460372597061f572beee6c325009fef618c42, GUI treed37b888016199ab7470993e24dde1c14b3296d5e. Synthetic in-memory API fixtures; desktop1440x963, interactions and screenshots inspected. Remote tests separately verify actual API/storage behavior.Checklist
Maintainer integration decision (MAINTAINERS.md, dev-only admin integration): @lidge-jun integrates lane D's manual chain (#3877 → #3902 → #3903 → #3904 → #3905) into
devbottom-up. Chain-top evidence at headfe9460372: Cross-platform CI run 34120761219 — Linux test 1/4–4/4, macOS 1/2, 2/2, gates (GUI 1787/0, lint, typecheck, privacy, build), storage policy, api usage, keyring ×3, npm-global ×3, docker smoke = success; Windows shards and macos control deferred to the final release-train head by maintainer policy. Prospective merge tree oforigin/dev@f4a4b468f+ top =ded24302f= tested tree. Independent per-layer reviews PASS; screenshots from this run's dashboard-preview artifact. Local suites NOT RUN. Maintainer integration, not self-approval.