Skip to content

feat(remote): carry bounded executor and hub runtime foundations - #4362

Draft
lidge-jun wants to merge 3 commits into
devfrom
codex/260912-60plus-remote-runtime
Draft

feat(remote): carry bounded executor and hub runtime foundations#4362
lidge-jun wants to merge 3 commits into
devfrom
codex/260912-60plus-remote-runtime

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • Independent source reviews passed after session-grant, secret-store, Linux executable-boundary and native availability corrections. The source-review outcome is not executable confinement evidence.
  • bun scripts/structure-ssot.ts --fix documentation consistency passed; git diff --check and relative-import path inspection passed.
  • Local product tests, typecheck, build, Cargo and installation: NOT RUN by explicit instruction. Regression code is included; final cumulative-tip hosted CI is tracked after integration. No intermediate-tip test pass is claimed.
  • Current workflows do not run native helper acceptance. Real Codex/Claude/Pi tests require their explicit environments; skipped paths remain unverified. Maintainer security/architecture review remains open. No pairing, remote operations or deployment were performed.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Current manual chain: #4344 (726ddc7fc0704c45299eef785e70624a07303784) -> #4362 (a3182185f0e089504d72e5729e4674cf0dc07ea1) -> #4372 (5c462fec1a1454a41e926a429acbdf1adf1e3bdf). Final hosted run 34675511791 is pending; no passing result is claimed. Maintainer security/architecture review is still required.

Carry #3458 runtime foundations with explicit session grants, private state stores and fail-closed Windows command support. Keep server and dashboard activation for the dependent integration layer.

Co-authored-by: Ingwannu <ingwannu@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@lidge-jun

Copy link
Copy Markdown
Owner Author

리뷰 · 우선순위 42 / 80

이 PR은 Remote Workspace의 executor·Hub 런타임 기초를 가져옵니다. 승인된 workspace root, 암호화 RPC, 세션 capability grant, 재연결, private state 발행이 포함됩니다. 모델 런타임 어댑터는 Hub에 두고, 이 레이어는 서버 활성화를 추가하지 않는다고 본문에 명시되어 있습니다. 원본 계보는 #3458이고, base는 codex/260912-60plus-remote(프로토콜 쪽)입니다.

머지 순서가 중요합니다. 안내된 체인: #4344 inactive workspace protocol → 이 PR(#4362) executor/hub foundations → #4372 dashboard/admission. 현재 dev(HEAD 81f6cd591)에는 src/remote-control/·native/ 디렉터리가 아직 없습니다. 즉 이 PR만 dev에 직접 합칠 수 없고, #4344가 만든 프로토콜·crypto·relay 기반 위에 올라갑니다. #4372는 다시 이 런타임 브랜치를 base로 둡니다.

규모가 큽니다(+9983/−47, 62 files). TypeScript 쪽은 workspace-executor·workspace-hub·workspace-rpc·workspace-sessions·workspace-device·CLI ocx remote-workspace이고, Rust helper(native/remote-workspace-helper)는 Windows/macOS sandbox probe·run과 바운드된 JSON 프로토콜을 가집니다. package.json에 helper build/test 스크립트와 files 목록 진입이 추가됩니다. 테스트 파일이 clients/ 아래에 다수입니다.

라인 / 심볼 - merge-order - #4344 미랜딩 상태에서 이 PR을 dev에 올리면 프로토콜 심볼이 없음. 스택 순서 고정 필요
경로/심볼 - native/remote-workspace-helper edition 2024 + windows-sys - CI에 Rust toolchain·타깃 매트릭스가 준비됐는지
경로/심볼 - RemoteWorkspaceSession 상한(MAX_LIVE_SESSIONS=8 등) - 제품 기본값으로 충분한지, Hub OOM 방어로 문서화했는지
경로/심볼 - encrypted RPC + secret store - 키 수명·파일 퍼미션·회전 정책이 #4372 admission과 모순 없는지
경로/심볼 - package.json files에 Cargo 소스 포함 - npm 패키지 무게·라이선스·prepublish 경로에 cargo가 필수가 되는지
경로/심볼 - 서버 활성화 없음 주장 - index export만 늘리고 management 라우트가 정말 안 붙었는지 #4372와 경계 재확인

메인테이너의 판단이 필요한 지점

너의 추천
지금 dev에 단독 머지하지 않는다. #4344를 먼저 안정화·랜딩(또는 스택 rebase)한 뒤 이 PR CI를 초록으로 만들고, 그 다음 #4372를 올린다. 중복·구식 remote carry가 있으면 close하고 이 체인만 남긴다. types/config 분리와 직접 충돌하진 않지만 스택이 밀리면 rebase 지옥 대신 close-후-재출을 택한다.

이 댓글은 grok-bot이 작성했습니다

Base automatically changed from codex/260912-60plus-remote to dev September 12, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant