Skip to content

feat(remote): integrate opt-in workspace dashboard and admission - #4372

Draft
lidge-jun wants to merge 8 commits into
codex/260912-60plus-remote-runtimefrom
codex/260912-60plus-remote-integration
Draft

feat(remote): integrate opt-in workspace dashboard and admission#4372
lidge-jun wants to merge 8 commits into
codex/260912-60plus-remote-runtimefrom
codex/260912-60plus-remote-integration

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • Final candidate: d1a922ae5f518bc73409eb2b201752835b4cb48d. Hosted lane=all run34693137770 and PR run34693115051 are pending. No all-green claim.
  • Failed predecessor34683454076 exposed a missing Host fixture and held-gate assertion ordering. Corrected fixture preconditions and native Promise observation preserve statuses and strengthen exact denial/error identity and no-execution assertions. Independent source review passed; repaired-head execution remains pending.
  • Local suites/build/typecheck/install/Cargo: NOT RUN. Documentation/source checks only. No live pairing, remote execution, deployment or merge performed by this task. Required maintainer security/architecture review remains open.
  • Rendered real hosted artifact10294424393 from merge-ref5270d422 with GUI tree69b1bce039ee18cecea2586bc484c2afe0523a13, matching the candidate GUI tree. Desktop1440x913 with synthetic example state, access-picker interaction observed, mutations disabled. Captures below prove layout only.

Read-only Remote Workspace

File-only Remote Workspace

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Current delivery state:

Carry #3458 dashboard and CLI wiring with explicit Hub opt-in, session-only mutations and awaited optional cleanup. Preserve current server and documentation owners; hosted preview and final cumulative CI remain pending.

Co-authored-by: Ingwannu <ingwannu@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@lidge-jun

Copy link
Copy Markdown
Owner Author

리뷰 · 우선순위 50 / 80

이 PR은 Remote Workspace 통합 tip입니다. dashboard GUI, executor CLI, pairing, agent WebSocket을 #3458 계열에서 이어 붙입니다. Hub는 OCX_REMOTE_WORKSPACE_ENABLED=1일 때만 서비스를 만들고, 꺼진 인스턴스는 status만 돌려 생성하지 않습니다. dashboard mutation은 browser session이 필요합니다. 체인: #4344 protocol → #4362 executor/runtime → 이 #4372. base는 codex/260912-60plus-remote-runtime이고 draft·UNSTABLE입니다. 현재 checkout /home/box/developer/opencodex에는 src/remote-control/ 자체가 아직 없습니다. 즉 지금 dev (81f6cd5, #4371 Cline 직후)와는 직접 fast-forward되지 않는 stacked tip입니다.

변경 규모는 +2910/-18, 파일 66개로 GUI i18n·페이지·management routes·ws-bridge·CLI registry·다수 테스트가 한번에 들어옵니다. Windows/macOS command execution은 계속 disabled이고, Windows functioning-command·native confinement는 open으로 남깁니다. co-author Ingwannu. #4371 journaled Cline 통합과는 제품 축이 다르지만, src/server/index.ts / ws-bridge.ts / management route-registry는 #4367 live sideband와도 접점이 있습니다. 원본 #3458 draft는 열린 채로 두고 closure를 주장하지 않습니다.

규모 대비 “opt-in flag + session grants + bounded bodies + awaited cleanup” 방향은 안전 쪽에 가깝습니다. 다만 tip을 dev에 단독 리뷰·머지하는 단위로는 너무 큽니다. runtime 부모 없이 GUI/admission만 보면 재현이 어렵습니다.

#4371이 Integrations dashboard/catalog sync를 넣은 직후라 GUI/management 표면이 방금 움직였습니다. Remote Workspace tip도 App 라우팅·사이드바·management route-registry를 만지므로, Cline GUI와 remote GUI를 같은 주에 겹쳐 올리면 회귀 면적이 큽니다. opt-in env로 기본 off라 런타임 위험은 낮지만, 리뷰·QA 비용은 큽니다.

경로 src/server/index.ts / ws-bridge.ts - #4367과 동시 착지 시 upgrade/handshake 계약이 겹칩니다. remote tip이 live pre-open socket 필드를 덮어쓰지 않는지 체인 머지 전에 확인하세요.

경로 GUI RemoteWorkspace.tsx + 다국어 - locale-parity 테스트가 있으나, 기능 flag off일 때 사이드바/라우팅이 완전히 숨기는지 제품 확인이 필요합니다.

경로 startup cleanup races - 두 번째 커밋이 그 문제를 다고 하니, 해당 테스트 이름을 CI에서 필수 게이트로 두세요.

메인테이너의 판단이 필요한 지점

너의 추천
draft 유지. 부모 runtime(#4362)까지 dev에 올린 뒤 tip을 승격하세요. 지금은 통합 리뷰만 하고 land하지 않는 편이 맞습니다. 점수 50은 “방향은 맞지만 스택·규모·CI가 아직” 구간의 중앙입니다.

이 댓글은 grok-bot이 작성했습니다

@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • UI screenshot required.

What to do

  • Add a screenshot of the UI change to the PR description.

This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

Hygiene

Deterministic PR hygiene checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant