Skip to content

LIM-2424 v6: Sean's Low follow-ups (plain wording, record link, dead code) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allsmog merged 1 commit into from
Oct 23, 2026
Merged

LIM-2424 v6: Sean's Low follow-ups (plain wording, record link, dead code) #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/GoalsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function TeamNode({ props, L, owner, sel, dim, onPick }: { props: ViewProps; L:
{g.measures.map((m) => (
<li key={m.id} className="flex flex-wrap items-baseline gap-2 text-[13.5px] text-zinc-600">
<span className="min-w-0 flex-1">{m.text}</span>
{owner === "security" && m.id === conflictId && open && <Pill tone="amber" small>{L.northstar ? `Clashes with ${companyMeasureId(s)}` : "In conflict"}</Pill>}
{owner === "security" && m.id === conflictId && open && <Pill tone="amber" small>{L.northstar ? "Clashes with the CEO's new requirement" : "In conflict"}</Pill>}
</li>
))}
</ul>
Expand Down Expand Up @@ -93,7 +93,7 @@ function selInfo(props: ViewProps, L: Labels, sel: Sel) {
const forward = L.northstar
? { cta: "See ways forward", run: () => openDrawer("brief") }
: { cta: me.actor === "product" ? "Open proposals" : "See proposals", run: () => go("proposals") };
const record = L.northstar ? { cta: "Open record", run: () => go("evidence") } : { cta: "Open proposals", run: () => go("proposals") };
const record = L.northstar ? { cta: "Open record", run: () => go("decision") } : { cta: "Open proposals", run: () => go("proposals") };
const next = st === "accepted" ? record : st === "pending" ? { cta: "Open proposal", run: () => go("proposals") } : forward;

if (sel === "ceo")
Expand Down Expand Up @@ -214,7 +214,7 @@ export function GoalsView(props: ViewProps) {
{ceo.changed && (
<span className="ml-auto">
<Pill tone="amber" small>
{`${ceo.measures.some((m) => m.id === krId) ? `${L.northstar ? krId : "Requirement"} changed` : "Changed"}${changedToday(ceo) ? " today" : ""}`}
{`${ceo.measures.some((m) => m.id === krId) ? "Requirement changed" : "Changed"}${changedToday(ceo) ? " today" : ""}`}
</Pill>
</span>
)}
Expand Down
14 changes: 1 addition & 13 deletions components/v6/OldPlanWork.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import { useState } from "react";
import { conflictMeasureId, labelsFor, poss, type Labels } from "@/lib/labels";
import type { StateView, WorkItem } from "@/lib/types";
import type { ViewProps } from "../props";
import { currentGoal, priorVersion } from "../select";
import { workFor } from "../TeamLens";
import { Button } from "../ui";
Expand Down Expand Up @@ -117,7 +116,7 @@ export function OldPlanWork({ s }: { s: StateView }) {
</div>
))}
{found && found.items.length === 0 && <p className="text-[15px] text-zinc-500">No work items are linked to the goal that changed.</p>}
<NotBuilt title="Keep, re-scope or stop, per item">Needs a decision field on work items. Not built yet.</NotBuilt>
<NotBuilt title="Keep, re-scope or stop, per item">Coming next: decide for each item whether to keep it, re-scope it or stop it.</NotBuilt>
<div className="flex flex-wrap items-center gap-3 border-t border-zinc-200 pt-4">
<span className="min-w-0 flex-1 text-[13.5px] text-zinc-500">
Nobody is notified automatically.
Expand All @@ -140,14 +139,3 @@ export function OldPlanWork({ s }: { s: StateView }) {
</section>
);
}

/** The whole v6 Work screen for either scenario: the cascade, then the old-plan sweep. */
export function WorkScreen(props: ViewProps) {
const L = labelsFor(props.s);
return (
<div className="flex flex-col gap-8">
<OldPlanWork s={props.s} />
<GoalCascade s={props.s} L={L} />
</div>
);
}
11 changes: 7 additions & 4 deletions components/v6/record.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export type RecordTab = "summary" | "receipts" | "legend";

const TABS: { id: RecordTab; label: string }[] = [
{ id: "summary", label: "Summary" },
{ id: "receipts", label: "Receipts" },
{ id: "receipts", label: "Activity" }, // results aren't signed (EvidenceView), so not "Receipts"
{ id: "legend", label: "How to read this" },
];

Expand Down Expand Up @@ -181,16 +181,19 @@ export function CopyText({ text }: { text: string }) {
function actionWords(action: string, L: Labels) {
const words: Record<string, string> = {
ceo_change_viewed: L.northstar ? "saw the CEO's change" : "saw the company goal change",
brief_reviewed: "read What to do next",
brief_reviewed: "read Ways forward",
scenario_reviewed: "opened the plan test",
evidence_opened: "opened Evidence",
evidence_opened: "opened the test results",
propose: "proposed a change",
counter: "asked for changes",
acknowledge: `accepted ${poss(L.team.security)} changes`,
ratify: "approved",
ratify_and_push_company_goal: "approved the company goal and sent it to every team",
saw_accepted_version: "saw the approved version",
launch: "decided the launch",
ratify_untested: "approved without a sandbox test",
reject: "declined the proposal",
launch_approved: "approved the launch",
launch_not_yet: "said not yet to the launch",
reset: "reset the demo",
};
return words[action] ?? action.replaceAll("_", " ");
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/0-fresh-leadership-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ SECURITY · PEER
v1
Handle customer and security issues quickly and correctly.
Close as many tickets as possible each day, oldest first
Clashes with KR2
Clashes with the CEO's new requirement
Critical security tickets keep getting the same careful handling
#1
Tag and answer every ticket, oldest first
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/0-fresh-leadership-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/0-fresh-product-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ SECURITY · PEER
v1
Handle customer and security issues quickly and correctly.
Close as many tickets as possible each day, oldest first
Clashes with KR2
Clashes with the CEO's new requirement
Critical security tickets keep getting the same careful handling
#1
Tag and answer every ticket, oldest first
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/0-fresh-product-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/0-fresh-security-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ SECURITY · YOU
v1
Handle customer and security issues quickly and correctly.
Close as many tickets as possible each day, oldest first
Clashes with KR2
Clashes with the CEO's new requirement
Critical security tickets keep getting the same careful handling
#1
Tag and answer every ticket, oldest first
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/0-fresh-security-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
4 changes: 2 additions & 2 deletions test/snapshots/ui-northstar-v6/1-org-pushed-leadership-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand All @@ -60,7 +60,7 @@ SECURITY · PEER
v1
Handle customer and security issues quickly and correctly.
Close as many tickets as possible each day, oldest first
Clashes with KR2
Clashes with the CEO's new requirement
Critical security tickets keep getting the same careful handling
#1
Tag and answer every ticket, oldest first
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/1-org-pushed-leadership-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
4 changes: 2 additions & 2 deletions test/snapshots/ui-northstar-v6/1-org-pushed-product-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand All @@ -70,7 +70,7 @@ SECURITY · PEER
v1
Handle customer and security issues quickly and correctly.
Close as many tickets as possible each day, oldest first
Clashes with KR2
Clashes with the CEO's new requirement
Critical security tickets keep getting the same careful handling
#1
Tag and answer every ticket, oldest first
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/1-org-pushed-product-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
4 changes: 2 additions & 2 deletions test/snapshots/ui-northstar-v6/1-org-pushed-security-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand All @@ -69,7 +69,7 @@ SECURITY · YOU
v1
Handle customer and security issues quickly and correctly.
Close as many tickets as possible each day, oldest first
Clashes with KR2
Clashes with the CEO's new requirement
Critical security tickets keep getting the same careful handling
#1
Tag and answer every ticket, oldest first
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/1-org-pushed-security-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/2-pending-security-leadership-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/2-pending-security-leadership-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/2-pending-security-product-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/2-pending-security-product-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/2-pending-security-security-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/2-pending-security-security-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/3-countered-product-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/3-countered-product-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/3-countered-security-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/3-countered-security-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/4-acknowledged-product-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/4-acknowledged-product-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/4-acknowledged-security-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/4-acknowledged-security-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/5-stale-acknowledged-product-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/5-stale-acknowledged-product-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/5-stale-acknowledged-security-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/5-stale-acknowledged-security-work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Work still on the old plan
No approved decision yet, so nothing to move.

Keep, re-scope or stop, per item
Needs a decision field on work items. Not built yet.
Coming next: decide for each item whether to keep it, re-scope it or stop it.
Nobody is notified automatically.
Copy a nudge for the owner
COMPANY GOAL → TEAM GOALS → WORK
Expand Down
2 changes: 1 addition & 1 deletion test/snapshots/ui-northstar-v6/6-ratified-leadership-goals.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Security
COMPANY · CEO
read-only
v2
KR2 changed today
Requirement changed today
Launch the beta of our new monitoring product, with support ready to help beta customers quickly and safely.
KR1 · Product says the beta is ready to launch
KR2 · Beta customers' issues handled first: marked urgent, tagged as beta, a private note for engineers, and a reply to the customer → Security
Expand Down
Loading