Repository navigation
LIM-2424 v6: Sean's Low follow-ups (plain wording, record link, dead code) - #11
Merged
Merged
Conversation
This was referenced Oct 23, 2026
allsmog
approved these changes
Oct 23, 2026
allsmog
left a comment
allsmog
left a comment
Contributor
There was a problem hiding this comment.
Approved @ 6f3f6ef. Read the diff. This covers my Lows: "Clashes with the CEO's new requirement" and "Requirement changed" replace KR2, Northstar's Open record goes to the record, the tab is Activity and no longer Receipts, the activity wording is current (including declined and launch actions), there's plain copy on the not-built card, and unused WorkScreen is removed. The snapshot changes match these copy edits. Gate: I'll run it on main after the merges.
…code) From Sean's #7 review (items 4 to 6) and the review in comment 6356535154: - Record: the "Receipts" tab is now "Activity". The results aren't signed (EvidenceView says so), so "Receipts" overclaimed. - Goals (Northstar): "Clashes with KR2" is back to "Clashes with the CEO's new requirement", and "KR2 changed today" is "Requirement changed today", as in custom scenarios. - Goals (Northstar): "Open record" opens the decision record, not the old Evidence screen. - Record audit and touchpoint wording: "read Ways forward", "opened the test results", plus plain words for the actions the server writes (ratify_untested, reject, launch_approved, launch_not_yet). The dead "launch" key is removed. - Work: "Needs a decision field on work items. Not built yet." is now user copy ("Coming next: ..."), and the unused WorkScreen export is gone. Northstar UI baseline re-captured: exactly those four strings change (Activity, Clashes with the CEO's new requirement, Requirement changed today, the Coming next line), in 39 files. Nothing else. Left for a founder or Sean call (wording or design): P0/P1/P2 in the brief, raw plan ids on the Studio cards, raw state chips in the thread, scripts/run-plan.sh lines on the test-results screen, and removing the unreachable pre-agreement branches of DecisionView and TodayView. Gate: scripts/test-all.sh 3247, all 15 steps pass (ui-loop 34/34, tenancy 166/166, scenario 73/73 x3, ui-northstar 125 files identical to the new baseline).
allsmog
force-pushed
the
fix/LIM-2424-v6-lows
branch
from
October 23, 2026 16:21
6f3f6ef to
832254d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sean's Low follow-ups from his #7 review (items 4 to 6). One commit,
6f3f6efce72f09f769af25f96f98ccb4aba78790, stacked on #10: merge #10 first, then retarget this to main.Changes
ratify_untested,reject,launch_approvedandlaunch_not_yet; the deadlaunchkey is removed. The unusedWorkScreenexport is removed.ui-northstar re-baseline (needs your sign-off)
Exactly four strings change, in 39 files, and nothing else: "Activity", "Clashes with the CEO's new requirement", "Requirement changed today", and the "Coming next" line.
Left for a founder or Sean call
scripts/run-plan.shlines on the test-results screenGate
scripts/test-all.sh 3247: all 15 steps pass (ui-loop 34/34, tenancy 166/166, scenario 73/73 ×3, ui-northstar 125 files identical to the new baseline).https://claude.ai/code/session_01JTqypyDqMz25L5fgdzcRWF