Skip to content

LIM-2424 v6: a declined proposal is visible to the asking team - #13

Merged
allsmog merged 1 commit into
mainfrom
fix/LIM-2424-v6-decline
Oct 23, 2026
Merged

allsmog merged 1 commit into
mainfrom
fix/LIM-2424-v6-decline

Conversation

@liminalshruti

Copy link
Copy Markdown
Collaborator

Sean's #7 integration-pass follow-up (Medium, 04:13Z): a declined proposal had no screen. ProposalsView tells the owner the asking team "sees that you declined", but Decisions filtered out REJECTED and Your turn skipped it. One commit, d1d821d91b7ac2bef229b4b91e4ce5c50773a341, stacked on #11: merge #10 → #11 → this, retargeting each to main.

Changes

  • Decisions: declined proposals are listed with a "Declined" pill, "Declined by · ", the time of the reject audit event, and a Declined filter (shown once there is one). A row opens the proposal.
  • Your turn: when the latest proposal was declined, the asking team's "Propose a change" card says " declined your last proposal."

Test (fail before, pass after)

test-ui-loop U14: fresh fixture → the asking team proposes → the owner declines → the asking team's Your turn and Decisions both name the decline. With the component change removed, U14 fails; with it, it passes. U10 now reads the agent's wake-ups before U14 replaces the scenario, which clears them.

Not here (from the same follow-up)

Gate

scripts/test-all.sh 3247: all 15 steps pass (ui-loop 35/35; ui-northstar 125 files unchanged against the v6 baseline, because Northstar never declines in the snapshot flow).

https://claude.ai/code/session_01JTqypyDqMz25L5fgdzcRWF

@allsmog allsmog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @ d1d821d. Read the diff. Declined proposals now show in Decisions (with a Declined filter when there are any), and the asking team's Your turn says the owner declined their last proposal, so the copy at ProposalsView "sees that you declined" is true (my item 7). U14 drives the decline path end to end. Gate: I'll run it on main after the merges.

@allsmog
allsmog force-pushed the fix/LIM-2424-v6-lows branch from 6f3f6ef to 832254d Compare October 23, 2026 16:21
Sean's #7 integration-pass follow-up (Medium): ProposalsView tells the owner
"<asking team> sees that you declined", but nothing showed it. DecisionsView
filtered out REJECTED and Your turn skipped it, so after a Decline the asking
team only got a fresh "Propose a change" card.

- Decisions lists declined proposals: a "Declined" pill, "Declined by <owner> ·
  <target>", the time of the reject audit event, and a Declined filter shown
  once there is one. A row opens the proposal.
- Your turn: when the latest proposal was declined, the asking team's
  "Propose a change" card says "<owner> declined your last proposal."

Test: test-ui-loop U14 (fresh fixture → propose → owner declines → the asking
team's Your turn and Decisions both name the decline). It fails with the
component change removed and passes with it. U10 now reads the agent's
wake-ups before U14 replaces the scenario, which clears them.

Gate: scripts/test-all.sh 3247, all 15 steps pass (ui-loop 35/35,
ui-northstar 125 files unchanged against the v6 baseline).
@allsmog
allsmog force-pushed the fix/LIM-2424-v6-decline branch from d1d821d to ab59e64 Compare October 23, 2026 16:23
@allsmog
allsmog changed the base branch from fix/LIM-2424-v6-lows to main October 23, 2026 16:24
@allsmog
allsmog merged commit 526081f into main Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants