Repository navigation
LIM-2424 v6: a declined proposal is visible to the asking team - #13
Merged
Merged
Conversation
allsmog
approved these changes
Oct 23, 2026
allsmog
left a comment
Contributor
There was a problem hiding this comment.
Approved @ d1d821d. Read the diff. Declined proposals now show in Decisions (with a Declined filter when there are any), and the asking team's Your turn says the owner declined their last proposal, so the copy at ProposalsView "sees that you declined" is true (my item 7). U14 drives the decline path end to end. Gate: I'll run it on main after the merges.
allsmog
force-pushed
the
fix/LIM-2424-v6-lows
branch
from
October 23, 2026 16:21
6f3f6ef to
832254d
Compare
Sean's #7 integration-pass follow-up (Medium): ProposalsView tells the owner "<asking team> sees that you declined", but nothing showed it. DecisionsView filtered out REJECTED and Your turn skipped it, so after a Decline the asking team only got a fresh "Propose a change" card. - Decisions lists declined proposals: a "Declined" pill, "Declined by <owner> · <target>", the time of the reject audit event, and a Declined filter shown once there is one. A row opens the proposal. - Your turn: when the latest proposal was declined, the asking team's "Propose a change" card says "<owner> declined your last proposal." Test: test-ui-loop U14 (fresh fixture → propose → owner declines → the asking team's Your turn and Decisions both name the decline). It fails with the component change removed and passes with it. U10 now reads the agent's wake-ups before U14 replaces the scenario, which clears them. Gate: scripts/test-all.sh 3247, all 15 steps pass (ui-loop 35/35, ui-northstar 125 files unchanged against the v6 baseline).
allsmog
force-pushed
the
fix/LIM-2424-v6-decline
branch
from
October 23, 2026 16:23
d1d821d to
ab59e64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sean's #7 integration-pass follow-up (Medium, 04:13Z): a declined proposal had no screen. ProposalsView tells the owner the asking team "sees that you declined", but Decisions filtered out
REJECTEDand Your turn skipped it. One commit,d1d821d91b7ac2bef229b4b91e4ce5c50773a341, stacked on #11: merge #10 → #11 → this, retargeting each to main.Changes
Test (fail before, pass after)
test-ui-loopU14: fresh fixture → the asking team proposes → the owner declines → the asking team's Your turn and Decisions both name the decline. With the component change removed, U14 fails; with it, it passes. U10 now reads the agent's wake-ups before U14 replaces the scenario, which clears them.Not here (from the same follow-up)
act()): belongs on or after LIM-2437: QA-exit gaps (error page + noscript, hosted no-answer copy, cross-tab role switch) #12, where the cross-tabsameSession()check lives. Routing it now would also turn the 403 into act()'s global error instead of "Handed back" (U5b).Gate
scripts/test-all.sh 3247: all 15 steps pass (ui-loop 35/35; ui-northstar 125 files unchanged against the v6 baseline, because Northstar never declines in the snapshot flow).https://claude.ai/code/session_01JTqypyDqMz25L5fgdzcRWF