Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Add "Deploy to Azure" button#7

Open
hoisjp wants to merge 3 commits into
line:masterfrom
hoisjp:master
Open

Add "Deploy to Azure" button#7
hoisjp wants to merge 3 commits into
line:masterfrom
hoisjp:master

Conversation

@hoisjp
Copy link
Copy Markdown

@hoisjp hoisjp commented Jul 18, 2019

I added "Deploy to Azure" button which deploys Azure App Service (free plan by default) with one click action.

If a base repo can accept this merge, please tell me. I will change the forked URL to the base URL before merging.
e.g. https://github.com/hoisjp/line-liff-starter => https://github.com/line/line-liff-starter

Copy link
Copy Markdown

@smwilk smwilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR. I left a comment about initialization of the deploy process. Could you please confirm it?

Comment thread README.md
[![Deploy to Azure](https://azuredeploy.net/deploybutton.svg)](https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fhoisjp%2Fline-liff-starter%2Fmaster%2Fazuredeploy.json)

1. Click the above "Deploy to Azure" button.
2. Fill in the required information on the "Custom deployment" page in Azure portal.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoisjp Thank you for submitting your pull request. When I hit the Deploy to Azure button, it redirects me to the Azure portal page. I'm not able to find Custom Deployment which is mentioned in the Deploying the application in the portal. Is this expected?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smwilk thank you for your review.
I tried again in an Incognito mode. I see "Custom Deployment" screen after hitting the button (and Azure account login) as expected like below.
image

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing the screenshot. I'm currently seeking help from the Microsoft customer support team. I will keep you posted on the progress. Thank you for your patience.

@smwilk
Copy link
Copy Markdown

smwilk commented Aug 22, 2019

@hoisjp Thanks for your patience.
I was able to see the "custom deployment" screen, but I kept getting a "Cannot find SourceControlToken" error.
It seemed like one's Github account needed to be linked to Azure, and the linked repository's URL had to be specified in the "Custom Deployment" page.
Following the below steps allowed me to successfully deploy the app:

  1. (First time only) Register one's Github account under "Deployment Center" in Azure portal.
  2. Fork the repository.
  3. Click the "Deploy to Azure" button in the forked repository.
  4. Set the forked repository URL in "Repo url" under SETTINGS (e.g. https://github.com/{your-github-username}/line-liff-starter ).
  5. Fill out the rest of the blanks as outlined here, and click "purchase".

Do you think there could be a workaround to this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants