This repository was archived by the owner on Mar 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 194
Add "Deploy to Azure" button #7
Open
hoisjp
wants to merge
3
commits into
line:master
Choose a base branch
from
hoisjp:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| { | ||
| "$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "parameters": { | ||
| "webSiteName": { | ||
| "type": "string", | ||
| "metadata": { | ||
| "description": "Web site name to define ***.azurewebsites.net . (need to be unique)" | ||
| } | ||
| }, | ||
| "skuAppSvcPlan": { | ||
| "type": "string", | ||
| "allowedValues": [ | ||
| "F1", | ||
| "D1", | ||
| "B1", | ||
| "S1" | ||
| ], | ||
| "defaultValue": "F1", | ||
| "metadata": { | ||
| "description": "The SKU of App Service Plan, Free F1 by default." | ||
| } | ||
| }, | ||
| "repoUrl": { | ||
| "type": "string", | ||
| "defaultValue": "https://github.com/hoisjp/line-liff-starter" | ||
| }, | ||
| "branch": { | ||
| "type": "string", | ||
| "defaultValue": "master" | ||
| } | ||
| }, | ||
| "variables": { | ||
| "appSvcPlanName": "[concat('appSvcPlan-', parameters('webSiteName'))]" | ||
| }, | ||
| "resources": [ | ||
| { | ||
| "type": "Microsoft.Web/serverfarms", | ||
| "apiVersion": "2018-02-01", | ||
| "kind": "app", | ||
| "name": "[variables('appSvcPlanName')]", | ||
| "location": "[resourceGroup().location]", | ||
| "sku": { | ||
| "name": "[parameters('skuAppSvcPlan')]" | ||
| }, | ||
| "properties": { | ||
| "name": "[variables('appSvcPlanName')]" | ||
| } | ||
| }, | ||
| { | ||
| "type": "Microsoft.Web/sites", | ||
| "apiVersion": "2018-11-01", | ||
| "name": "[parameters('webSiteName')]", | ||
| "location": "[resourceGroup().location]", | ||
| "dependsOn": [ | ||
| "[resourceId('Microsoft.Web/serverfarms', variables('appSvcPlanName'))]" | ||
| ], | ||
| "kind": "app", | ||
| "properties": { | ||
| "enabled": true, | ||
| "hostNameSslStates": [ | ||
| { | ||
| "name": "[concat(parameters('webSiteName'), '.azurewebsites.net')]", | ||
| "sslState": "Disabled", | ||
| "hostType": "Standard" | ||
| }, | ||
| { | ||
| "name": "[concat(parameters('webSiteName'), '.scm.azurewebsites.net')]", | ||
| "sslState": "Disabled", | ||
| "hostType": "Repository" | ||
| } | ||
| ], | ||
| "serverFarmId": "[resourceId('Microsoft.Web/serverfarms', variables('appSvcPlanName'))]", | ||
| "reserved": false, | ||
| "scmSiteAlsoStopped": false, | ||
| "clientAffinityEnabled": true, | ||
| "clientCertEnabled": false, | ||
| "hostNamesDisabled": false, | ||
| "containerSize": 0, | ||
| "dailyMemoryTimeQuota": 0, | ||
| "httpsOnly": false | ||
| }, | ||
| "resources": [ | ||
| { | ||
| "type": "sourcecontrols", | ||
| "apiVersion": "2018-11-01", | ||
| "name": "web", | ||
| "dependsOn": [ | ||
| "[resourceId('Microsoft.Web/sites', parameters('webSiteName'))]", | ||
| "[concat('Microsoft.Web/Sites/', parameters('webSiteName'), '/config/web')]" | ||
| ], | ||
| "properties": { | ||
| "repoUrl" : "[parameters('repoUrl')]", | ||
| "branch": "[parameters('branch')]" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "type": "Microsoft.Web/sites/config", | ||
| "apiVersion": "2018-11-01", | ||
| "name": "[concat(parameters('webSiteName'), '/web')]", | ||
| "location": "[resourceGroup().location]", | ||
| "dependsOn": [ | ||
| "[resourceId('Microsoft.Web/sites', parameters('webSiteName'))]" | ||
| ], | ||
| "properties": { | ||
| "numberOfWorkers": 1, | ||
| "defaultDocuments": [ | ||
| "index.html", | ||
| "index.php" | ||
| ], | ||
| "phpVersion": "7.3", | ||
| "localMySqlEnabled": false, | ||
| "http20Enabled": false, | ||
| "minTlsVersion": "1.2", | ||
| "ftpsState": "Disabled", | ||
| "reservedInstanceCount": 0 | ||
| } | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoisjp Thank you for submitting your pull request. When I hit the
Deploy to Azurebutton, it redirects me to the Azure portal page. I'm not able to findCustom Deploymentwhich is mentioned in the Deploying the application in the portal. Is this expected?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smwilk thank you for your review.
I tried again in an Incognito mode. I see "Custom Deployment" screen after hitting the button (and Azure account login) as expected like below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for sharing the screenshot. I'm currently seeking help from the Microsoft customer support team. I will keep you posted on the progress. Thank you for your patience.