Skip to content

Conversation

@joe-from-mtl
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Dec 16, 2024

Hello @joe-from-mtl! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-16 21:24:16 UTC

Copy link
Contributor

@CHrlS98 CHrlS98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joe-from-mtl I don't know if this PR is still relevant, but if so here's my review.

publishDir path: "${params.output_directory}", mode: "copy"
script:
"""
linum_estimate_xyShift_fromMetadata $directory shifts_xy.csv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these script names won't work with our new build system. You need the .py at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants