Repository navigation
fix(vt): switch VT through wlroots session - #913
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds running CTest-based unit tests to Arch Linux CI workflows for waylib and treeland and aligns CMake presets to support the new CI test step. Flow diagram for updated Arch Linux CI pipeline with CTestflowchart TD
A[Checkout code] --> B[Configure with cmake --preset ci]
B --> C[Build with cmake --build --preset ci]
C --> D[Run tests with ctest --preset ci]
D --> E[Install to staging directory]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
treeland-archlinux-build.yml, the newctest --preset cistep runs without settingworking-directory, unlike the waylib workflow; consider specifying the build directory so tests run against the correct CMake build tree.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `treeland-archlinux-build.yml`, the new `ctest --preset ci` step runs without setting `working-directory`, unlike the waylib workflow; consider specifying the build directory so tests run against the correct CMake build tree.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
zccrs
force-pushed
the
master
branch
2 times, most recently
from
June 2, 2026 03:11
394fd31 to
c6d5a3f
Compare
Member
Author
Member
Author
Use direct wlroots/libseat VT switching and remove the old DDM VT detour. 使用wlroots/libseat直接切换VT,并移除旧的DDM VT绕路。 Remove the input device revoke workaround, align the systemd dependency with dde-seatd.service, and require ddm newer than 0.3.4. 移除输入设备revoke兼容逻辑,将systemd依赖切换为dde-seatd.service,并要求ddm版本高于0.3.4。 Log: 修复切换tty的功能,之前存在切换到tty后又闪现会treeland的问题 Influence: 通过Ctrl+Alt+Fn快捷键或chvt命令切换tty的功能
Groveer
approved these changes
Jun 2, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Groveer, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
commitlint的检查不用管,第二个commit是在github上直接编辑的,所有问题,合并时会将两个commit压缩到一起。 |
zccrs
added a commit
to zccrs/treeland
that referenced
this pull request
Jun 9, 2026
* fix(vt): switch VT through wlroots session Use direct wlroots/libseat VT switching and remove the old DDM VT detour. 使用wlroots/libseat直接切换VT,并移除旧的DDM VT绕路。 Remove the input device revoke workaround, align the systemd dependency with dde-seatd.service, and require ddm newer than 0.3.4. 移除输入设备revoke兼容逻辑,将systemd依赖切换为dde-seatd.service,并要求ddm版本高于0.3.4。 Log: 修复切换tty的功能,之前存在切换到tty后又闪现会treeland的问题 Influence: 通过Ctrl+Alt+Fn快捷键或chvt命令切换tty的功能
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates Treeland VT handling for the dde-seatd/vt-bound flow.
dde-seatd.serviceThis is the Treeland side of the DDM + Treeland VT switching cleanup.
Summary by Sourcery
Run CTest-based unit tests in CI for waylib and treeland builds.
CI:
ctest --preset cito waylib Arch Linux CI workflow.ctest --preset cito treeland Arch Linux CI workflow.