chore: clean up README, gut app.plugin.js to no-op, and fix compileSdkVersion (#7)#8
Conversation
…kVersion (#7) * chore: clean up README, gut app.plugin.js to no-op, and fix compileSdkVersion - Remove stale GitHub Packages references from README - Fix compileSdkVersion to 36+ to match build.gradle - Update Publishing section for automated CI/CD flow - Replace app.plugin.js with a no-op placeholder * fix(docs): revert compileSdkVersion to 35+ in README Workaround in build.gradle still pins core-ktx to 1.13.1 to support consumers on compileSdk 35.
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR removes the Gradle repository-injecting Expo config plugin in favor of a passthrough no-op, clarifies Android SDK requirements ( ChangesPlugin Simplification & Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request simplifies the library's setup by removing the need for manual Maven repository configuration in both the documentation and the Expo config plugin. The README.md was updated to reflect a more streamlined installation process, remove obsolete troubleshooting steps, and document the new automated publishing workflow using GitHub Actions for stable and beta releases. I have no feedback to provide.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app.plugin.js (1)
1-1: ⚡ Quick winConsider importing
expo/config-pluginsre-export instead of@expo/config-pluginsdirectly.According to Expo's documentation, importing through the
expopackage re-export (expo/config-plugins) ensures alignment with the version expected by the consumer'sexpodependency. Direct imports from@expo/config-pluginscan resolve to incompatible versions or fail under strict package managers (PnP). To adopt this pattern, update the import and adjustpeerDependenciesto declareexpoinstead of@expo/config-plugins:Proposed change
-const { createRunOncePlugin } = require('@expo/config-plugins'); +const { createRunOncePlugin } = require('expo/config-plugins');In
package.json:-"peerDependencies": { - "@expo/config-plugins": ">=7.0.0", + +"peerDependencies": { + "expo": ">=50.0.0",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app.plugin.js` at line 1, Update the import in app.plugin.js to use the Expo re-export by importing createRunOncePlugin from "expo/config-plugins" instead of "@expo/config-plugins", and update package.json peerDependencies to list "expo" (with an appropriate version range) instead of "@expo/config-plugins" so consumers resolve the config-plugins version that matches their expo dependency; ensure any references to createRunOncePlugin continue to work after the switch.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@app.plugin.js`:
- Line 1: Update the import in app.plugin.js to use the Expo re-export by
importing createRunOncePlugin from "expo/config-plugins" instead of
"@expo/config-plugins", and update package.json peerDependencies to list "expo"
(with an appropriate version range) instead of "@expo/config-plugins" so
consumers resolve the config-plugins version that matches their expo dependency;
ensure any references to createRunOncePlugin continue to work after the switch.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 21d7214c-ebe5-45ec-ad20-625d9a5786c2
📒 Files selected for processing (2)
README.mdapp.plugin.js
Workaround in build.gradle still pins core-ktx to 1.13.1 to support consumers on compileSdk 35.