Skip to content

chore: clean up README, gut app.plugin.js to no-op, and fix compileSdkVersion (#7)#8

Merged
prashantdixittt merged 1 commit into
mainfrom
release/1.0.1
May 7, 2026
Merged

chore: clean up README, gut app.plugin.js to no-op, and fix compileSdkVersion (#7)#8
prashantdixittt merged 1 commit into
mainfrom
release/1.0.1

Conversation

@prashantdixittt
Copy link
Copy Markdown
Collaborator

  • chore: clean up README, gut app.plugin.js to no-op, and fix compileSdkVersion
  • Remove stale GitHub Packages references from README
    • Fix compileSdkVersion to 36+ to match build.gradle
    • Update Publishing section for automated CI/CD flow
    • Replace app.plugin.js with a no-op placeholder
  • fix(docs): revert compileSdkVersion to 35+ in README

Workaround in build.gradle still pins core-ktx to 1.13.1 to support consumers on compileSdk 35.

…kVersion (#7)

* chore: clean up README, gut app.plugin.js to no-op, and fix compileSdkVersion

- Remove stale GitHub Packages references from README
  - Fix compileSdkVersion to 36+ to match build.gradle
  - Update Publishing section for automated CI/CD flow
  - Replace app.plugin.js with a no-op placeholder

* fix(docs): revert compileSdkVersion to 35+ in README

Workaround in build.gradle still pins core-ktx to 1.13.1
to support consumers on compileSdk 35.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Documentation

    • Updated Android minimum and target SDK version requirements for enhanced compatibility (minSdkVersion 24, compileSdkVersion 35+)
    • Clarified platform-specific setup instructions for React Native CLI and Expo, noting that Expo Go is not supported and development builds are required
    • Added publishing workflow documentation with automated GitHub Actions examples for stable and pre-release versions
  • Chores

    • Simplified build configuration

Walkthrough

This PR removes the Gradle repository-injecting Expo config plugin in favor of a passthrough no-op, clarifies Android SDK requirements (minSdkVersion: 24, compileSdkVersion: 35+), simplifies setup instructions (React Native CLI needs no additional steps; Expo Go unsupported, dev build required), and replaces the troubleshooting section with GitHub Actions-based publishing workflow documentation for stable and beta releases.

Changes

Plugin Simplification & Documentation

Layer / File(s) Summary
Expo Plugin Implementation
app.plugin.js
Config plugin behavior replaced: no longer injects Gradle repository blocks; now passes through Expo config unchanged via createRunOncePlugin.
Android Requirements & Setup Instructions
README.md
minSdkVersion: 24 and compileSdkVersion: 35+ are explicitly documented; React Native CLI marked "No additional setup required"; Expo Go declared unsupported with development build requirement emphasized.
Publishing & Build Process
README.md
Troubleshooting "Build" guidance removed; Publishing section rewritten to document automated GitHub Actions workflows triggered by v* tags with yarn release (stable) and yarn release --preRelease=beta (beta) commands.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly matches the primary changes: cleaning up README, converting app.plugin.js to a no-op, and fixing compileSdkVersion.
Description check ✅ Passed The description is related to the changeset, detailing the README cleanup, app.plugin.js gutting, and compileSdkVersion adjustments across commits.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/1.0.1

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the library's setup by removing the need for manual Maven repository configuration in both the documentation and the Expo config plugin. The README.md was updated to reflect a more streamlined installation process, remove obsolete troubleshooting steps, and document the new automated publishing workflow using GitHub Actions for stable and beta releases. I have no feedback to provide.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
app.plugin.js (1)

1-1: ⚡ Quick win

Consider importing expo/config-plugins re-export instead of @expo/config-plugins directly.

According to Expo's documentation, importing through the expo package re-export (expo/config-plugins) ensures alignment with the version expected by the consumer's expo dependency. Direct imports from @expo/config-plugins can resolve to incompatible versions or fail under strict package managers (PnP). To adopt this pattern, update the import and adjust peerDependencies to declare expo instead of @expo/config-plugins:

Proposed change
-const { createRunOncePlugin } = require('@expo/config-plugins');
+const { createRunOncePlugin } = require('expo/config-plugins');

In package.json:

-"peerDependencies": {
-  "@expo/config-plugins": ">=7.0.0",
+
+"peerDependencies": {
+  "expo": ">=50.0.0",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app.plugin.js` at line 1, Update the import in app.plugin.js to use the Expo
re-export by importing createRunOncePlugin from "expo/config-plugins" instead of
"@expo/config-plugins", and update package.json peerDependencies to list "expo"
(with an appropriate version range) instead of "@expo/config-plugins" so
consumers resolve the config-plugins version that matches their expo dependency;
ensure any references to createRunOncePlugin continue to work after the switch.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@app.plugin.js`:
- Line 1: Update the import in app.plugin.js to use the Expo re-export by
importing createRunOncePlugin from "expo/config-plugins" instead of
"@expo/config-plugins", and update package.json peerDependencies to list "expo"
(with an appropriate version range) instead of "@expo/config-plugins" so
consumers resolve the config-plugins version that matches their expo dependency;
ensure any references to createRunOncePlugin continue to work after the switch.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 21d7214c-ebe5-45ec-ad20-625d9a5786c2

📥 Commits

Reviewing files that changed from the base of the PR and between b0992d8 and 5396269.

📒 Files selected for processing (2)
  • README.md
  • app.plugin.js

@prashantdixittt prashantdixittt merged commit 893e56b into main May 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant