Skip to content

test(server): bring two selective-timeline e2e cases up to the current contract #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
longbkit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(server): bring two selective-timeline e2e cases up to the current contract #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/server/src/server/selective-timeline-delivery.e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,9 +471,10 @@ test("a background timeline listener does not keep an agent resident and still f
await setBackgroundTimelineSubscription(listener, [agent.id]);
expect(manager.isAgentTimelineViewed(agent.id)).toBe(false);

await viewer.client.setAgentTimelineSubscription([agent.id]);
// A viewer's set keeps the agent resident; clearing it lets the agent go.
await viewer.setLegacyTimelineMembership([agent.id]);
expect(manager.isAgentTimelineViewed(agent.id)).toBe(true);
await viewer.client.setAgentTimelineSubscription([]);
await viewer.setLegacyTimelineMembership([]);
expect(manager.isAgentTimelineViewed(agent.id)).toBe(false);

await daemon.daemon.agentManager.closeAgent(agent.id);
Expand Down Expand Up @@ -804,9 +805,16 @@ test("plugin items are gated in provider child streams, child fetches, and rewin
const oldChild = await legacy.client.fetchProviderSubagentTimeline(agent.id, "child");
const newChild = await capable.client.fetchProviderSubagentTimeline(agent.id, "child");
expect(newChild.rows.map((row) => row.item)).toContainEqual(plugin);
// A fetch keeps every row, so the window matches: an item an older client
// cannot render becomes an upgrade line, and none of its data is sent.
expect(oldChild.rows.map((row) => row.item)).toEqual([
{
type: "assistant_message",
text: "Please upgrade Clisbot to view this subagent conversation.",
},
{ type: "assistant_message", text: "Child result" },
]);
expect(JSON.stringify(oldChild.rows)).not.toContain("Provider notice");
expect(oldChild.window).toEqual(newChild.window);

await capable.client.sendMessage(agent.id, "Rewind target");
Expand Down
Loading