fix: prepend node_modules/.bin to PATH for npm/npx execution#906
Merged
Conversation
When `vx npm run <script>` is called on Windows, npm's internal PATH prepend (adding node_modules/.bin for script execution) can fail when the environment is explicitly set via Command::env(). This causes locally-installed binaries like tsc, vite, etc. to not be found. As a defensive safety net, vx now prepends the local node_modules/.bin directory to PATH when executing npm or npx commands, mirroring what npm does internally. The directory is only added if it actually exists on disk. Fixes the "'tsc' is not recognized" error in dcc-mcp-core's build.rs when running `vx npm run build` from the admin-ui/ directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
loonghao
added a commit
that referenced
this pull request
May 26, 2026
* fix: prepend node_modules/.bin to PATH for npm/npx execution When `vx npm run <script>` is called on Windows, npm's internal PATH prepend (adding node_modules/.bin for script execution) can fail when the environment is explicitly set via Command::env(). This causes locally-installed binaries like tsc, vite, etc. to not be found. As a defensive safety net, vx now prepends the local node_modules/.bin directory to PATH when executing npm or npx commands, mirroring what npm does internally. The directory is only added if it actually exists on disk. Fixes the "'tsc' is not recognized" error in dcc-mcp-core's build.rs when running `vx npm run build` from the admin-ui/ directory. * chore: regenerate workspace-hack (cargo-hakari) [skip ci] --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
loonghao
added a commit
that referenced
this pull request
May 26, 2026
* fix: prepend node_modules/.bin to PATH for npm/npx execution When `vx npm run <script>` is called on Windows, npm's internal PATH prepend (adding node_modules/.bin for script execution) can fail when the environment is explicitly set via Command::env(). This causes locally-installed binaries like tsc, vite, etc. to not be found. As a defensive safety net, vx now prepends the local node_modules/.bin directory to PATH when executing npm or npx commands, mirroring what npm does internally. The directory is only added if it actually exists on disk. Fixes the "'tsc' is not recognized" error in dcc-mcp-core's build.rs when running `vx npm run build` from the admin-ui/ directory. * chore: regenerate workspace-hack (cargo-hakari) [skip ci]
This was referenced May 26, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vx npm run <script>executes on Windows, npm's internal PATH prepend fornode_modules/.bincan fail when the env is set explicitly viaCommand::env(), causing locally-installed binaries (tsc,vite, etc.) to not be found.node_modules/.bindirectory to PATH when executingnpmornpxcommands (only when the directory exists).'tsc' is not recognizederror indcc-mcp-core'sbuild.rswhen runningvx npm run build.Test plan
cargo nextest run --workspace)cargo clippy --workspace -- -D warningspasses with zero warningscargo fmt --all -- --checkpassesvx just devcompletes withouttscnot found error🤖 Generated with Claude Code