Skip to content

fix: harden release and runtime installs#914

Merged
loonghao merged 3 commits into
mainfrom
fix/release-skip-empty-dependencies
May 26, 2026
Merged

fix: harden release and runtime installs#914
loonghao merged 3 commits into
mainfrom
fix/release-skip-empty-dependencies

Conversation

@loonghao
Copy link
Copy Markdown
Owner

@loonghao loonghao commented May 26, 2026

Summary

  • Skip empty cargo-dist dependency-install steps and normalize apt installs with portable awk
  • Serialize runtime install verification so concurrent installs cannot treat a half-extracted executable as ready
  • Keep workspace-hack lockfile metadata current

Validation

  • vx actionlint .github/workflows/release.yml
  • vx cargo fmt --all
  • vx cargo test -p vx-runtime --test install_lock_tests
  • vx git diff --check

Notes

  • The Windows CI failure was a runtime install race: a second vx process could see node.exe before the first archive extraction finished, then Windows reported os error 193.

@loonghao loonghao marked this pull request as ready for review May 26, 2026 08:45
@loonghao loonghao changed the title fix: skip empty release dependency installs fix: harden release and runtime installs May 26, 2026
@loonghao loonghao force-pushed the fix/release-skip-empty-dependencies branch from 3726ee1 to 0406c6f Compare May 26, 2026 10:45
@loonghao loonghao force-pushed the fix/release-skip-empty-dependencies branch from 0406c6f to 92faa9a Compare May 26, 2026 10:48
@loonghao loonghao closed this May 26, 2026
@loonghao loonghao reopened this May 26, 2026
@loonghao loonghao merged commit e5dba77 into main May 26, 2026
@loonghao loonghao deleted the fix/release-skip-empty-dependencies branch May 26, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant