Support reasoning models (Luna, o1, o3) by skipping temperature parameter - #173
Merged
Merged
Conversation
…eter Rename _is_thinking_model to _is_reasoning_model and expand detection to cover OpenAI reasoning models (o1, o3) and GPT-5.6 Luna, which reject temperature=0. Only Claude reasoning models get the thinking budget; other reasoning models simply omit temperature. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lukeinglis
marked this pull request as ready for review
August 24, 2026 17:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the Luna compatibility issue.
Changes
_is_thinking_modelto_is_reasoning_modeland expanded detection to cover OpenAI reasoning models (o1,o3) and GPT-5.6 Luna, which rejecttemperature=0_forecast_kwargsso reasoning models skip the temperature parameter entirely, while only Claude reasoning models get the thinking budget