Skip to content

Support reasoning models (Luna, o1, o3) by skipping temperature parameter #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukeinglis merged 1 commit into from
Aug 24, 2026
Merged

Support reasoning models (Luna, o1, o3) by skipping temperature parameter #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lab_forecaster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,13 @@ def _format_question_text(text: str, forecast_due_date: str, is_dataset: bool) -
return text


def _is_thinking_model(model: str) -> bool:
return "claude" in model.lower() and THINKING_BUDGET > 0
def _is_reasoning_model(model: str) -> bool:
model_lower = model.lower()
if "claude" in model_lower and THINKING_BUDGET > 0:
return True
if any(x in model_lower for x in ["o1", "o3", "luna"]):
return True
return False


def _forecast_kwargs(
Expand All @@ -224,8 +229,9 @@ def _forecast_kwargs(
"vertex_location": VERTEX_LOCATION,
}

if _is_thinking_model(effective_model):
kwargs["thinking"] = {"type": "enabled", "budget_tokens": THINKING_BUDGET}
if _is_reasoning_model(effective_model):
if "claude" in effective_model.lower():
kwargs["thinking"] = {"type": "enabled", "budget_tokens": THINKING_BUDGET}
else:
kwargs["temperature"] = TEMPERATURE

Expand Down
Loading