Own review cancellation, recovery, and shutdown lifecycles - #117
Own review cancellation, recovery, and shutdown lifecycles#117lynnswap wants to merge 38 commits into
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d90be36316
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Wave 3B checkpoint pushed at Focused gates are green (AppServer 130, Host 47, MCP HTTP 25, attempt processor 39; compatibility and ReviewMonitor 15/15 were green at the runtime checkpoint). This Ready PR is intentionally not merge-ready yet: the remaining shared-force-close sibling replacement and additive replayable |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Purpose
Make cancellation, recovery, and application/MCP shutdown authoritative and joined. Completion is published only after the canonical review terminal and every owned operation, session, channel, and task has drained.
Advances #106. It remains open until Wave 4 adds durable terminal commit-before-cleanup.
Changes
CodexReviewStore.close() async throwsand serialize Store, Host, MCP, and ReviewMonitor termination.Closes #118.
Closes #119.
Closes #120.
Testing
swift test --build-system swiftbuild --no-parallelSWIFTNIO_STRICT=1, including five repeated warning scansscripts/check-compatibility.shxcodebuild testScreenshots
Not applicable; this PR changes lifecycle and protocol behavior.