Own review cancellation, recovery, and shutdown lifecycles

Fixtures/CodexReviewKitProductConsumer/Sources/CodexReviewKitProductConsumer/main.swift

@@ -7,7 +7,7 @@ import TextTransitions
 @main
 @MainActor
 struct CodexReviewKitProductConsumer {
-    static func main() {
+    static func main() async throws {
         let lifecycleInitializer: (
             ReviewJobState,
             Int?,
@@ -73,6 +73,7 @@ struct CodexReviewKitProductConsumer {
             fatalError("TextTransitions public rendering contract drifted.")
         }
 
+        try await store.close()
         withExtendedLifetime((store, windowController, transitionView)) {}
         print("CodexReviewKit public product consumer passed.")
     }

Sources/CodexReview/CodexReviewBackend.swift

@@ -10,17 +10,34 @@ package protocol CodexReviewBackend: Sendable {
     func completeLogin(_ response: CodexReviewBackendModel.Login.Response) async throws -> CodexReviewBackendModel.Auth.Snapshot
     func logout(_ account: CodexReviewBackendModel.Account.ID) async throws -> CodexReviewBackendModel.Auth.Snapshot
 
-    func startReview(_ request: CodexReviewBackendModel.Review.Start) async throws -> BackendReviewAttempt
+    func startReview(
+        _ request: CodexReviewBackendModel.Review.Start,
+        admission: ReviewStartAdmission
+    ) async throws -> BackendReviewAttempt
     func interruptReview(_ run: CodexReviewBackendModel.Review.Run, reason: CodexReviewBackendModel.CancellationReason) async throws
-    func beginReviewRecovery(
-        _ run: CodexReviewBackendModel.Review.Run,
-        reason: CodexReviewBackendModel.CancellationReason
-    ) async throws -> CodexReviewBackendModel.Review.RecoveryToken
+    func forceCloseReviewConnection() async throws
+    func prepareReviewRecovery(
+        _ candidate: ReviewRecoveryCandidate
+    ) async throws -> ReviewRecoveryHandoff
     func resumeReviewRecovery(
-        _ token: CodexReviewBackendModel.Review.RecoveryToken,
-        request: CodexReviewBackendModel.Review.Start
+        _ handoff: ReviewRecoveryHandoff,
+        request: CodexReviewBackendModel.Review.Start,
+        admission: ReviewStartAdmission
     ) async throws -> BackendReviewAttempt
-    func cleanupReview(_ run: CodexReviewBackendModel.Review.Run) async
+    func cleanupReview(_ run: CodexReviewBackendModel.Review.Run) async throws
+}
+
+package extension CodexReviewBackend {
+    func startReview(
+        _ request: CodexReviewBackendModel.Review.Start
+    ) async throws -> BackendReviewAttempt {
+        let admission = ReviewStartAdmission()
+        let registered = try await admission.registerStart { admission in
+            try await self.startReview(request, admission: admission)
+        }
+        try await admission.activateStart(registered.id)
+        return try await registered.task.value
+    }
 }
 
 package struct BackendReviewAttempt: Sendable {
@@ -36,15 +53,13 @@ package struct BackendReviewAttempt: Sendable {
 package actor BackendReviewEventMailbox {
     private enum Terminal {
         case finished
-        case cancelled
-        case failed(String)
+        case failed(ReviewAttemptStreamFailure)
     }
 
     private enum Delivery {
         case event(CodexReviewBackendModel.Review.Event)
         case finished
-        case cancelled
-        case failed(String)
+        case failed(ReviewAttemptStreamFailure)
     }
 
     private var bufferedEvents: [CodexReviewBackendModel.Review.Event] = []
@@ -59,10 +74,8 @@ package actor BackendReviewEventMailbox {
             return event
         case .finished:
             return nil
-        case .cancelled:
-            throw CancellationError()
-        case .failed(let message):
-            throw BackendReviewEventMailboxError(message: message)
+        case .failed(let failure):
+            throw failure
         }
     }
 
@@ -96,11 +109,11 @@ package actor BackendReviewEventMailbox {
         resumeWaitersForTerminal()
     }
 
-    package func fail(_ error: any Error) {
+    package func fail(_ failure: ReviewAttemptStreamFailure) {
         guard terminal == nil else {
             return
         }
-        terminal = error is CancellationError ? .cancelled : .failed(error.localizedDescription)
+        terminal = .failed(failure)
         resumeWaitersForTerminal()
     }
 
@@ -166,8 +179,6 @@ package actor BackendReviewEventMailbox {
         switch terminal {
         case .finished:
             return .finished
-        case .cancelled:
-            return .cancelled
         case .failed(let message):
             return .failed(message)
         }
@@ -183,18 +194,6 @@ package actor BackendReviewEventMailbox {
     }
 }
 
-package struct BackendReviewEventMailboxError: LocalizedError, Sendable {
-    package var message: String
-
-    package init(message: String) {
-        self.message = message
-    }
-
-    package var errorDescription: String? {
-        message
-    }
-}
-
 package struct CodexReviewClock: Sendable {
     package var now: @Sendable () -> Date