Skip to content

🔒 Fix MITM vulnerability by enforcing strict TLS verification #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maattyi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🔒 Fix MITM vulnerability by enforcing strict TLS verification #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/domain_fronter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ def __init__(self, config: dict):
self.mode = mode
self.worker_path = config.get("worker_path", "")
self.auth_key = config.get("auth_key", "")
self.verify_ssl = config.get("verify_ssl", True)

# Connection pool — TTL-based, pre-warmed, with concurrency control
self._pool: list[tuple[asyncio.StreamReader, asyncio.StreamWriter, float]] = []
Expand Down Expand Up @@ -96,7 +95,7 @@ def __init__(self, config: dict):
from h2_transport import H2Transport, H2_AVAILABLE
if H2_AVAILABLE:
self._h2 = H2Transport(
self.connect_host, self.sni_host, self.verify_ssl
self.connect_host, self.sni_host
)
log.info("HTTP/2 multiplexing available — "
"all requests will share one connection")
Expand All @@ -107,9 +106,6 @@ def __init__(self, config: dict):

def _ssl_ctx(self) -> ssl.SSLContext:
ctx = ssl.create_default_context()
if not self.verify_ssl:
ctx.check_hostname = False
ctx.verify_mode = ssl.CERT_NONE
return ctx

async def _open(self):
Expand Down
7 changes: 1 addition & 6 deletions src/h2_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,9 @@ class H2Transport:
- Configurable max concurrency
"""

def __init__(self, connect_host: str, sni_host: str,
verify_ssl: bool = True):
def __init__(self, connect_host: str, sni_host: str):
self.connect_host = connect_host
self.sni_host = sni_host
self.verify_ssl = verify_ssl

self._reader: asyncio.StreamReader | None = None
self._writer: asyncio.StreamWriter | None = None
Expand Down Expand Up @@ -102,9 +100,6 @@ async def _do_connect(self):
ctx = ssl.create_default_context()
# Advertise both h2 and http/1.1 — some DPI blocks h2-only ALPN
ctx.set_alpn_protocols(["h2", "http/1.1"])
if not self.verify_ssl:
ctx.check_hostname = False
ctx.verify_mode = ssl.CERT_NONE

# Create raw TCP socket with TCP_NODELAY BEFORE TLS handshake.
# Nagle's algorithm can delay small writes (H2 frames) by up to 200ms
Expand Down
3 changes: 0 additions & 3 deletions src/proxy_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,9 +364,6 @@ async def _do_sni_rewrite_tunnel(self, host: str, port: int, reader, writer,

# Step 2: open outgoing TLS to target IP with the safe SNI
ssl_ctx_client = ssl.create_default_context()
if not self.fronter.verify_ssl:
ssl_ctx_client.check_hostname = False
ssl_ctx_client.verify_mode = ssl.CERT_NONE
try:
r_out, w_out = await asyncio.wait_for(
asyncio.open_connection(
Expand Down