Repository navigation
fix: the EDS results header and exports name the kept region - #69
Merged
Merged
Conversation
The results header, the export file stem, the results and spectrum CSVs, the .msa title and Auto ID's region now read the kept region's own name (Region 1, Region 2, or what it was renamed to) instead of "Region" for every shape, so two regions' exports no longer overwrite each other. Reported in mac4DSTEM/macTEM#99. Done: the kept region's name reaches the header and the exports; next: macTEM takes the next MacEMUI version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul
Fixes mac4DSTEM/macTEM#99.
What. In the EDS room, the results header (
Results · …), the export file stem, the results and spectrum CSVs' region line, the.msatitle and Auto ID's region now use the kept region's own name:Region 1,Region 2, or whatever it was renamed to. Before, every shape readRegion. A shape that is selected but not kept still readsRegion.Why. Driving per-region composition on Paul's real Velox spectrum images (macTEM's new
EDXRegionsRealFileJourney, 1339 file) showedResults · Regionfor both Region 1 and Region 2. Results CSV wrote…_Region quantification.csvfor each, so the second export overwrote the first. The region table and the spectrum legend already saidRegion 1/Region 2.Tests.
EDXRegionsTests.testTheHeaderAndTheExportsNameTheKeptRegion(new) fails onmain("Region" != "Region 2", stemplanted_Region) and passes here.swift test -c release --parallelis green.Screen. This changes one line of text in the results header. The before screenshot is from Paul's private data, so it stays local, not in this public PR. The after state is unverified on screen until macTEM takes this version.
Not numeric. No public API change.
🤖 Generated with Claude Code