Repository navigation
fix: green the CI gate — lazy onnx import + mypy version target - #5
Merged
Merged
Conversation
Two pre-existing 1.0.0 gate failures unrelated to any feature: - test_package_imports[jaxility.policy] failed with 'No module named onnx': onnx_export.py imported onnx at module top, so importing the policy subpackage required the optional [policy] extra. Make it lazy (a _require_onnx() guard raising a structured ToolchainError at call time), matching litert/executorch/quantize. Import now succeeds without the extra; export fails loudly. - mypy failed on the 3.12 runner: numpy's 3.12 stubs use a PEP 695 'type' statement that mypy rejected under the pinned python_version=3.10. Drop the pin so mypy targets each matrix runner's own interpreter; the 3.10 runner still enforces 3.10 compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last two pre-existing 1.0.0 gate failures (both unrelated to any feature):
test_package_imports[jaxility.policy]→No module named 'onnx':onnx_export.pyimported onnx at module top, so importing the policy subpackage needed the optional[policy]extra. Made it lazy — a_require_onnx()guard raising a structuredToolchainErrorat call time (matchinglitert/executorch/quantize). Verified: import succeeds without the extra; export fails loudly.mypyfailed on the 3.12 runner: numpy's 3.12 stubs use a PEP 695typestatement mypy rejected under the pinnedpython_version = 3.10. Dropped the pin so mypy targets each runner's own interpreter; the 3.10 runner still enforces 3.10 compat.🤖 Generated with Claude Code