Repository navigation
T-112: enforce cross-toolchain integrity in the build path - #6
Merged
Merged
Conversation
The attestation story leans on toolchain provenance, but the SHA-256 integrity check (verify_toolchain_integrity) was exported and never called by any build — so the manifest silently implied a check that never ran. - Add resolve_toolchain_integrity(target): the build-path policy. Real pin -> verify the installed binary; a mismatch (or missing binary) raises ToolchainError and aborts the build. Unverified sentinel -> record "unverified" and continue (loud, not silent). - Wire it into cross_build_for_target: a "verify"-stage build-log entry plus a toolchain-integrity:<binary> key in Manifest.toolchain_versions, so a verifier can tell whether provenance covers toolchain integrity. - Doc-drift: CLAIMS gains the integrity-status claim; KNOWN_GAPS updates the (now honest) placeholder-SHA entry. Tests: resolve_toolchain_integrity over unverified / pinned-match / pinned-mismatch. Pinning the real Arm hashes stays a gap (host-specific).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attestation pitch leans on toolchain provenance, but
verify_toolchain_integritywas exported and never called by any build — the manifest silently implied a check that never ran.What
resolve_toolchain_integrity(target)— the build-path policy. Real pin → verify the installed binary; a mismatch (or missing binary) raisesToolchainErrorand aborts the build. Unverified sentinel → record"unverified"and continue (loud, not silent — invariant 7).cross_build_for_target: averify-stage build-log entry + atoolchain-integrity:<binary>key inManifest.toolchain_versions, so a verifier can tell whether provenance covers toolchain integrity.Tests
resolve_toolchain_integrityover unverified / pinned-match / pinned-mismatch (hard-fail). Pinning the real Arm hashes stays a documented gap (host-specific per release).🤖 Generated with Claude Code