Repository navigation
fix(chart): refuse more than one manager replica without leader election - #177
Merged
Merged
Conversation
maks3201
enabled auto-merge (squash)
October 12, 2026 13:02
Ami-inka
approved these changes
Oct 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
maks3201
pushed a commit
that referenced
this pull request
Oct 13, 2026
🤖 I have created a release *beep* *boop* --- ## [0.5.1](v0.5.0...v0.5.1) (2026-10-13) ### Bug Fixes * bound Recreate stable-stop wait ([#165](#165)) ([aa80a7b](aa80a7b)) * **chart:** refuse more than one manager replica without leader election ([#177](#177)) ([a3ae3af](a3ae3af)) * clear the Recreate stop marker when the spec returns to a failed revision ([2e06304](2e06304)) * do not fail a prefetch as DigestMismatch when the manifest cannot be read ([#174](#174)) ([fad7194](fad7194)) * do not park a candidate for manual approval while the stable is stopped for a Recreate rollout ([660d49c](660d49c)) * do not re-render a legacy stable when its Deployment cannot be read ([2e06304](2e06304)) * drop the candidate manifest when the spec reverts to a failed revision ([#176](#176)) ([3abaa9e](3abaa9e)) * end the store and load stabilization grace at promotion plus the Starting timeout ([#178](#178)) ([824fd51](824fd51)) * finish a Recreate rollout as Recreate after the stable is stopped, including a replacement candidate ([2e06304](2e06304)) * keep a freshly promoted stable while its store recovers or its model loads ([#173](#173)) ([4f3a0c4](4f3a0c4)) * keep admission-added Service port fields instead of rewriting them every reconcile ([2e06304](2e06304)) * remove the manifest ConfigMap of a candidate whose admission did not persist ([660d49c](660d49c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With replicaCount > 1 and leaderElection: false every manager replica reconciled the same DecisionModels at once. The chart now fails to render that combination with a clear message and documents the HA setup in the README. Verified with helm lint and helm template: defaults and replicaCount=2 render; replicaCount=2 with leaderElection=false fails.