fix(mop): default Group::SetTargetIcon context arg so 3-arg callers compile - #18
Merged
Merged
Conversation
… compile The 5.4.8 group-markers restore (6b7978e) added a required `uint8 context` parameter to Group::SetTargetIcon, breaking every 3-argument caller -- notably the shared Eluna Group:SetTargetIcon binding (build error C2660). Give the new parameter a default of 0 (a normal target-icon set) so existing 3-arg callers stay source-compatible and no Eluna change is needed. Builds clean against stock Eluna (fd0b208a); 218/218 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 5.4.8 raid-markers restore (
6b7978ec9) gaveGroup::SetTargetIcona newrequired fourth parameter —
uint8 context— so its signature became(uint8 id, ObjectGuid whoGuid, ObjectGuid targetGuid, uint8 context). Thatbroke every existing 3-argument caller, most importantly the shared Eluna
Group:SetTargetIconbinding, which fails to compile against the mangos-fourcore with:
Because
MangosServer/Elunais shared across all cores (Classic/TBC/WotLK/Cata/MoP), it can't call the 4-arg overload unconditionally without breaking the
other cores. The clean fix is core-side: give the new parameter a default.
Change
src/game/WorldHandlers/Group.h— default the newcontextargument to0:context = 0is a normal target-icon set (matchingGroupHandler's defaultpath). All existing 4-arg callers keep working and the pre-MoP 3-arg call is
source-compatible again — so stock Eluna needs no change.
Testing
fd0b208a), no submodule change.Supersedes MangosServer/Eluna#8 (close it) — the fix belongs in the core that
changed the signature.
🤖 Generated with Claude Code
This change is