Skip to content

fix(mop): default Group::SetTargetIcon context arg so 3-arg callers compile #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MadMaxMangos merged 1 commit into from
Jul 22, 2026
Merged

fix(mop): default Group::SetTargetIcon context arg so 3-arg callers compile #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/game/WorldHandlers/Group.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,8 +1063,10 @@ class Group
}
}

// context defaults to 0 (a normal target-icon set) so pre-MoP 3-argument callers --
// notably Eluna's shared Group:SetTargetIcon binding -- stay source-compatible.
void SetTargetIcon(uint8 id, ObjectGuid whoGuid, ObjectGuid targetGuid,
uint8 context);
uint8 context = 0);

Difficulty GetDifficulty(bool isRaid) const { return isRaid ? m_raidDifficulty : m_dungeonDifficulty; }
Difficulty GetDungeonDifficulty() const { return m_dungeonDifficulty; }
Expand Down