Repository navigation
fix(preconf): restore pending eligibility after slice execution - #265
Merged
adam-xu-mantle merged 2 commits intoNov 19, 2026
Merged
adam-xu-mantle merged 2 commits into
adam-xu-mantle merged 2 commits into
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ordinary submissions can become stuck when slice maintenance prunes an executed transaction before removing a stale lower-nonce transaction from the same sender. The pool can lose its candidate index, then select a later arrival ahead of lower transactions that are still pending, causing repeated
NonceTooHighrejections.Use
remove_transactionsfollowed by the existing nonce and balance update inmaintain_pool_at_slice_boundary. Removal temporarily parks descendants; the account update promotes eligible successors in nonce order before the builder takes its next iterator. This avoids leaving the pending sub-pool with the problematic nonce gap, without changingpatches/reth-transaction-pool/src/pool/pending.rsor any other pool implementation.Preserve transaction hashes in the pool-maintenance test helper, add a regression for a stale lower-nonce transaction with an executed successor, and cover five continuously sending accounts across slice and block boundaries.
Behavioral implications
The existing removal API emits
discardednotifications for transactions removed after execution. Descendants may move from pending to queued and back at each boundary, adding pool maintenance work and promotion notifications. The final eligibility check still uses the executed sender nonce and balance; unreadable balances continue to park transactions. The underlying generic pruning limitation remains unchanged for other callers.Test plan
just prpassed locally: fmt, clippy, workspace tests, version checks, 376 integration tests, and default/all-feature doctests. Three integration tests were skipped; nextest reported one unrelated test asLEAK.The Python reproducer sends ordinary transactions at approximately 10 TPS and resubmits nonces 0, 1, and 2 with changed contents after 700 ms. These results establish that scenario; they do not establish that unique, monotonically increasing submissions alone always trigger the defect or identify the exact trigger of the existing qa3 sample.
Local validation uses
0f33a084a4881687ecd334ea4c41481ddc4e753fplus the final Mantle-only patch. The targetdev/mantle-v1.7.0was 65 commits ahead of that baseline when the PR was created, with identical contents for the changed files before this patch. Integration with the latest target remains subject to PR CI. No qa3 deployment has been performed.