Draft
Conversation
| @@ -0,0 +1,30 @@ | |||
| import React, { ReactNode, FormEvent, KeyboardEvent } from 'react'; | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
Temporary added until recat-submittable is upgraded
tristen
reviewed
Mar 17, 2026
| // Following the instructions provided by Radix on handling disabled | ||
| // button elements: Since disabled buttons don't fire events, you need to: | ||
| // - Render the Trigger as `span`. | ||
| // @ts-expect-error - child.props.disabled may exist on button elements |
Member
There was a problem hiding this comment.
I'm not inferring from the comment why is this necessary?
tristen
reviewed
Mar 17, 2026
|
|
||
| test('render border', () => { | ||
| render(<TabsWithBorder />); | ||
| expect(screen.getByTestId('tabs-wrapper')).toHaveClass('border-b border--gray-light mb-neg1'); |
| await userEvent.hover(screen.getByRole('slider')); | ||
| const { container } = render(<ControlRange {...props} />); | ||
| const thumb = screen.getByRole('slider'); | ||
| fireEvent.mouseOver(thumb); |
Member
There was a problem hiding this comment.
Hmm this might impact tests upstream if userEvent had previously worked
| children: ReactNode; | ||
| } | ||
|
|
||
| export default function Submittable({ onEnter, onCancel, children, ...rest }: SubmittableProps) { |
Member
There was a problem hiding this comment.
Probably fine and likely what's in the original package but ...rest seems a little insecure?
|
|
||
| await waitFor(() => { | ||
| expect(screen.getByRole('dialog')).toBeInTheDocument(); | ||
| expect(screen.getByRole('dialog', { hidden: true })).toBeInTheDocument(); |
Member
There was a problem hiding this comment.
This hidden: true stuff seems suspicious
Member
There was a problem hiding this comment.
Not seeing any issues running this locally and testing it out at least!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.