Skip to content

Upgrade to react 19 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
badiuoanaalexandra wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Upgrade to react 19 #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd26f20
Upgrade to react 19
badiuoanaalexandra Mar 17, 2026
d03f97c
Fix lint errors
tristen Mar 17, 2026
364ddb9
Fix runtime compile errors
tristen Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,988 changes: 2,370 additions & 1,618 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

45 changes: 22 additions & 23 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,27 +30,26 @@
},
"peerDependencies": {
"prop-types": "^15.7.2",
"react": "^16.14.0 || ^18.2.0",
"react-dom": "^16.14.0 || ^18.2.0"
"react": "^16.14.0 || ^18.2.0 || ^19.0.0",
"react-dom": "^16.14.0 || ^18.2.0 || ^19.0.0"
},
"dependencies": {
"@mapbox/mbx-assembly": "^1.6.0",
"@mapbox/query-selector-contains-node": "^1.0.0",
"@mapbox/react-submittable": "^3.0.1",
"@radix-ui/react-accessible-icon": "^1.0.3",
"@radix-ui/react-accordion": "^1.1.2",
"@radix-ui/react-context-menu": "^2.1.5",
"@radix-ui/react-dialog": "^1.0.5",
"@radix-ui/react-label": "^2.0.2",
"@radix-ui/react-popover": "^1.0.7",
"@radix-ui/react-portal": "^1.0.4",
"@radix-ui/react-select": "^2.0.0",
"@radix-ui/react-slider": "^1.1.2",
"@radix-ui/react-switch": "^1.0.3",
"@radix-ui/react-tabs": "^1.0.4",
"@radix-ui/react-toast": "^1.1.5",
"@radix-ui/react-tooltip": "^1.0.7",
"@radix-ui/react-visually-hidden": "^1.0.3",
"@radix-ui/react-accessible-icon": "^1.1.8",
"@radix-ui/react-accordion": "^1.2.12",
"@radix-ui/react-context-menu": "^2.2.16",
"@radix-ui/react-dialog": "^1.1.15",
"@radix-ui/react-label": "^2.1.8",
"@radix-ui/react-popover": "^1.1.15",
"@radix-ui/react-portal": "^1.1.10",
"@radix-ui/react-select": "^2.2.6",
"@radix-ui/react-slider": "^1.3.6",
"@radix-ui/react-switch": "^1.2.6",
"@radix-ui/react-tabs": "^1.1.13",
"@radix-ui/react-toast": "^1.2.15",
"@radix-ui/react-tooltip": "^1.2.8",
"@radix-ui/react-visually-hidden": "^1.2.4",
"classnames": "^2.2.6",
"clipboard": "^2.0.0",
"debounce": "^1.1.0",
Expand All @@ -62,12 +61,12 @@
"@babel/cli": "^7.18.6",
"@mapbox/jsxtreme-markdown": "^0.9.3",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.1",
"@testing-library/react": "^16.3.0",
"@testing-library/user-event": "^14.5.2",
"@types/jest": "^29.5.12",
"@types/node": "^16.11.43",
"@types/react": "^17.0.47",
"@types/react-dom": "^18.0.6",
"@types/react": "^19.0.0",
"@types/react-dom": "^19.0.0",
"del": "^3.0.0",
"delay": "^3.0.0",
"execa": "^0.10.0",
Expand All @@ -82,10 +81,10 @@
"pify": "^3.0.0",
"prettier": "^2.3.1",
"prismjs": "^1.15.0",
"react": "^18.2.0",
"react": "^19.0.0",
"react-app-rewired": "^2.2.1",
"react-docgen": "^5.4.3",
"react-dom": "^18.2.0",
"react-dom": "^19.0.0",
"react-scripts": "5.0.1",
"typescript": "^4.7.4",
"web-vitals": "^2.1.4"
Expand Down Expand Up @@ -125,4 +124,4 @@
"pre-commit": "lint-staged"
}
}
}
}
72 changes: 36 additions & 36 deletions src/components/accordion/__snapshots__/accordion.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ exports[`Accordion all options renders 1`] = `
data-state="open"
>
<button
aria-controls="radix-:rp:"
aria-controls="radix-_r_p_"
aria-expanded="true"
class="w-full bg-red txt-l txt-bold link link--white bg-red-dark-on-hover px6 py6 cursor-pointer"
data-orientation="vertical"
data-radix-collection-item=""
data-state="open"
data-testid="accordion-trigger-one"
id="radix-:ro:"
id="radix-_r_o_"
type="button"
>
<div>
Expand All @@ -32,10 +32,10 @@ exports[`Accordion all options renders 1`] = `
</div>
</button>
<div
aria-labelledby="radix-:ro:"
aria-labelledby="radix-_r_o_"
data-orientation="vertical"
data-state="open"
id="radix-:rp:"
id="radix-_r_p_"
role="region"
style="--radix-accordion-content-height: var(--radix-collapsible-content-height); --radix-accordion-content-width: var(--radix-collapsible-content-width); transition-duration: 0s; animation-name: none;"
>
Expand All @@ -52,26 +52,26 @@ exports[`Accordion all options renders 1`] = `
data-state="closed"
>
<button
aria-controls="radix-:rr:"
aria-controls="radix-_r_r_"
aria-expanded="false"
class="w-full bg-red txt-l txt-bold link link--white bg-red-dark-on-hover px6 py6 cursor-pointer"
data-orientation="vertical"
data-radix-collection-item=""
data-state="closed"
data-testid="accordion-trigger-two"
id="radix-:rq:"
id="radix-_r_q_"
type="button"
>
<div>
two
</div>
</button>
<div
aria-labelledby="radix-:rq:"
aria-labelledby="radix-_r_q_"
data-orientation="vertical"
data-state="closed"
hidden=""
id="radix-:rr:"
id="radix-_r_r_"
role="region"
style="--radix-accordion-content-height: var(--radix-collapsible-content-height); --radix-accordion-content-width: var(--radix-collapsible-content-width);"
/>
Expand All @@ -82,26 +82,26 @@ exports[`Accordion all options renders 1`] = `
data-state="closed"
>
<button
aria-controls="radix-:rt:"
aria-controls="radix-_r_t_"
aria-expanded="false"
class="w-full bg-red txt-l txt-bold link link--white bg-red-dark-on-hover px6 py6 cursor-pointer"
data-orientation="vertical"
data-radix-collection-item=""
data-state="closed"
data-testid="accordion-trigger-third"
id="radix-:rs:"
id="radix-_r_s_"
type="button"
>
<div>
third
</div>
</button>
<div
aria-labelledby="radix-:rs:"
aria-labelledby="radix-_r_s_"
data-orientation="vertical"
data-state="closed"
hidden=""
id="radix-:rt:"
id="radix-_r_t_"
role="region"
style="--radix-accordion-content-height: var(--radix-collapsible-content-height); --radix-accordion-content-width: var(--radix-collapsible-content-width);"
/>
Expand All @@ -122,26 +122,26 @@ exports[`Accordion basic renders 1`] = `
data-state="closed"
>
<button
aria-controls="radix-:r1:"
aria-controls="radix-_r_1_"
aria-expanded="false"
class="w-full txt-s txt-bold txt-truncate link link--gray py6 cursor-pointer"
data-orientation="vertical"
data-radix-collection-item=""
data-state="closed"
data-testid="accordion-trigger-one"
id="radix-:r0:"
id="radix-_r_0_"
type="button"
>
<span>
one
</span>
</button>
<div
aria-labelledby="radix-:r0:"
aria-labelledby="radix-_r_0_"
data-orientation="vertical"
data-state="closed"
hidden=""
id="radix-:r1:"
id="radix-_r_1_"
role="region"
style="--radix-accordion-content-height: var(--radix-collapsible-content-height); --radix-accordion-content-width: var(--radix-collapsible-content-width);"
/>
Expand All @@ -151,26 +151,26 @@ exports[`Accordion basic renders 1`] = `
data-state="closed"
>
<button
aria-controls="radix-:r3:"
aria-controls="radix-_r_3_"
aria-expanded="false"
class="w-full txt-s txt-bold txt-truncate link link--gray py6 cursor-pointer"
data-orientation="vertical"
data-radix-collection-item=""
data-state="closed"
data-testid="accordion-trigger-two"
id="radix-:r2:"
id="radix-_r_2_"
type="button"
>
<span>
two
</span>
</button>
<div
aria-labelledby="radix-:r2:"
aria-labelledby="radix-_r_2_"
data-orientation="vertical"
data-state="closed"
hidden=""
id="radix-:r3:"
id="radix-_r_3_"
role="region"
style="--radix-accordion-content-height: var(--radix-collapsible-content-height); --radix-accordion-content-width: var(--radix-collapsible-content-width);"
/>
Expand All @@ -180,26 +180,26 @@ exports[`Accordion basic renders 1`] = `
data-state="closed"
>
<button
aria-controls="radix-:r5:"
aria-controls="radix-_r_5_"
aria-expanded="false"
class="w-full txt-s txt-bold txt-truncate link link--gray py6 cursor-pointer"
data-orientation="vertical"
data-radix-collection-item=""
data-state="closed"
data-testid="accordion-trigger-three"
id="radix-:r4:"
id="radix-_r_4_"
type="button"
>
<span>
three
</span>
</button>
<div
aria-labelledby="radix-:r4:"
aria-labelledby="radix-_r_4_"
data-orientation="vertical"
data-state="closed"
hidden=""
id="radix-:r5:"
id="radix-_r_5_"
role="region"
style="--radix-accordion-content-height: var(--radix-collapsible-content-height); --radix-accordion-content-width: var(--radix-collapsible-content-width);"
/>
Expand All @@ -220,26 +220,26 @@ exports[`Accordion disabled renders 1`] = `
data-state="closed"
>
<button
aria-controls="radix-:rd:"
aria-controls="radix-_r_d_"
aria-expanded="false"
class="w-full txt-s txt-bold txt-truncate link link--gray py6 cursor-pointer"
data-orientation="vertical"
data-radix-collection-item=""
data-state="closed"
data-testid="accordion-trigger-one"
id="radix-:rc:"
id="radix-_r_c_"
type="button"
>
<span>
one
</span>
</button>
<div
aria-labelledby="radix-:rc:"
aria-labelledby="radix-_r_c_"
data-orientation="vertical"
data-state="closed"
hidden=""
id="radix-:rd:"
id="radix-_r_d_"
role="region"
style="--radix-accordion-content-height: var(--radix-collapsible-content-height); --radix-accordion-content-width: var(--radix-collapsible-content-width);"
/>
Expand All @@ -249,26 +249,26 @@ exports[`Accordion disabled renders 1`] = `
data-state="closed"
>
<button
aria-controls="radix-:rf:"
aria-controls="radix-_r_f_"
aria-expanded="false"
class="w-full txt-s txt-bold txt-truncate link link--gray py6 cursor-pointer"
data-orientation="vertical"
data-radix-collection-item=""
data-state="closed"
data-testid="accordion-trigger-two"
id="radix-:re:"
id="radix-_r_e_"
type="button"
>
<span>
two
</span>
</button>
<div
aria-labelledby="radix-:re:"
aria-labelledby="radix-_r_e_"
data-orientation="vertical"
data-state="closed"
hidden=""
id="radix-:rf:"
id="radix-_r_f_"
role="region"
style="--radix-accordion-content-height: var(--radix-collapsible-content-height); --radix-accordion-content-width: var(--radix-collapsible-content-width);"
/>
Expand All @@ -278,27 +278,27 @@ exports[`Accordion disabled renders 1`] = `
data-state="closed"
>
<button
aria-controls="radix-:rh:"
aria-controls="radix-_r_h_"
aria-expanded="false"
class="w-full txt-s txt-bold txt-truncate link link--gray py6 cursor-default color-gray-light"
data-orientation="vertical"
data-radix-collection-item=""
data-state="closed"
data-testid="accordion-trigger-three"
disabled=""
id="radix-:rg:"
id="radix-_r_g_"
type="button"
>
<span>
three
</span>
</button>
<div
aria-labelledby="radix-:rg:"
aria-labelledby="radix-_r_g_"
data-orientation="vertical"
data-state="closed"
hidden=""
id="radix-:rh:"
id="radix-_r_h_"
role="region"
style="--radix-accordion-content-height: var(--radix-collapsible-content-height); --radix-accordion-content-width: var(--radix-collapsible-content-width);"
/>
Expand Down
2 changes: 1 addition & 1 deletion src/components/button/button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ interface Props {
size?: Size;
width?: Width;
ariaLabel?: string;
passthroughProps?: HTMLAttributes<HTMLButtonElement | HTMLAnchorElement>;
passthroughProps?: HTMLAttributes<HTMLElement> & { [key: `data-${string}`]: string };
}

function getSize(variant: Variant): Size {
Expand Down
6 changes: 3 additions & 3 deletions src/components/code-snippet/__snapshots__/code-snippet.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ exports[`CodeSnippet copy ranges renders as expected 1`] = `
style="display: contents;"
>
<div
aria-controls="radix-:r4:"
aria-controls="radix-_r_4_"
aria-expanded="false"
aria-haspopup="dialog"
data-state="closed"
Expand Down Expand Up @@ -389,7 +389,7 @@ exports[`CodeSnippet copy ranges renders as expected 1`] = `
style="display: contents;"
>
<div
aria-controls="radix-:r6:"
aria-controls="radix-_r_6_"
aria-expanded="false"
aria-haspopup="dialog"
data-state="closed"
Expand Down Expand Up @@ -625,7 +625,7 @@ exports[`CodeSnippet highlighted, no ranges, with onCopy callback renders as exp
style="display: contents;"
>
<div
aria-controls="radix-:r0:"
aria-controls="radix-_r_0_"
aria-expanded="false"
aria-haspopup="dialog"
data-state="closed"
Expand Down
Loading
Loading