feat: add dark mode reader cleanup setting - #5
Conversation
📝 WalkthroughWalkthroughVersion 0.1.5 of the dark-mode theme adds a configurable ChangesReader Cleanup Feature and Release Coordination
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
dark-mode-theme/README.md (1)
14-14: ⚡ Quick winConsider documenting the enum option behaviors.
The new "Reader cleanup" setting is mentioned, but the user-facing meaning of each option (
off,every-page,5-pages,10-pages) is not explained. Consider adding a brief explanation of when cleanup frames trigger for each option to help users make an informed choice.📝 Example documentation enhancement
-- exposes a `Reader cleanup` package setting for periodic dark reader cleanup frames to reduce ghosting +- exposes a `Reader cleanup` package setting for periodic dark reader cleanup frames to reduce ghosting: + - `off`: no cleanup frames + - `every-page`: cleanup after each page turn + - `5-pages`: cleanup every 5 pages (default) + - `10-pages`: cleanup every 10 pages🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@dark-mode-theme/README.md` at line 14, Add brief user-facing descriptions for the "Reader cleanup" enum options mentioned in README.md: document what each option (`off`, `every-page`, `5-pages`, `10-pages`) means in terms of when a dark-reader cleanup frame runs (e.g., never, after every page render, after N page navigations/frames), include expected effects (reduces ghosting at cost of extra frames) and the default value; update the "Reader cleanup" line to list each option and a one-sentence trigger/impact for users to choose appropriately.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@dark-mode-theme/README.md`:
- Line 14: Add brief user-facing descriptions for the "Reader cleanup" enum
options mentioned in README.md: document what each option (`off`, `every-page`,
`5-pages`, `10-pages`) means in terms of when a dark-reader cleanup frame runs
(e.g., never, after every page render, after N page navigations/frames), include
expected effects (reduces ghosting at cost of extra frames) and the default
value; update the "Reader cleanup" line to list each option and a one-sentence
trigger/impact for users to choose appropriately.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 95575ec2-f1f6-4f36-914e-c5045bad453b
📒 Files selected for processing (4)
README.mddark-mode-theme/README.mddark-mode-theme/manifest.jsondark-mode-theme/src/theme.json
Summary\n- bump Dark Mode to 0.1.5\n- add a package-owned Reader cleanup setting for dark reader refresh cadence\n- advertise the new theme descriptor contract in docs\n\n## Validation\n- python3 ../marginalia-sdk/tools/validate_manifest.py --profile publish */manifest.json\n- rebuild package archives with ../marginalia-sdk/tools/build_package.py\n- /Users/sabraman/.local/bin/coderabbit review --plain
Summary by CodeRabbit
New Features
Documentation