Skip to content

P0 UI-1: white transparent Command Dock chevron and power SVG, freeze FAT checkpoint - #646

Closed
masarray wants to merge 7 commits into
trial/arsas-command-leaf-fabric-20261020from
ui/command-dock-white-icons-20261020
Closed

masarray wants to merge 7 commits into
trial/arsas-command-leaf-fabric-20261020from
ui/command-dock-white-icons-20261020

Conversation

@masarray

Copy link
Copy Markdown
Owner

Frozen checkpoint

  • Exact CI-green combined FAT: 30a7f18e8e575604eb1306c96753daab9f9c4a51, immutable reference branch checkpoint/arsas-fat-green-20261020, Actions run 39404069355: all 11 CI workflows success, 2409 ARSAS + 24 engine + 6 packaged regression tests and portable smoke green.
  • User-tested 2026-10-20 field diagnostic application SHA de71a1a45c30d0221766c389d96553e051b20c17 on checkpoint/arsas-field-command-stable-20261020, with identical source tree to green FAT, positive SBOw/Operate/termination and feedback, ~414–461 ms valid click-to-result. Do not conflate local ~400ms post-SBOw wait with wire/IED termination latency.

Exactly Phase 1 only — visual change

  • Copy user-supplied exact filled SVG path contours for chevron DOWN / UP and power into immutable WPF Geometry resources. No raster scaling, external assets or new dependencies.
  • Scoped CommandDockTransparentHeaderExpander template only on CommandPanelExpander: white SVG on transparent dark header, chevron swaps via IsChecked/IsExpanded, accessible keyboard-click header, transparent interaction and keyboard focus indication only.
  • Remove 28x28 light-blue power card. Power becomes white glyph beside Command Dock label, keeping header target badge.
  • Reuse same Expander instance and original CommandPanel_Expanded/Collapsed handlers, DataGrid, command confirmation, typed control, SBOw/Operate and report traffic unchanged. No timers or MMS calls.
  • Add P109X source/markup regression and checkpoint document.

Important exclusions / release gate

Phase 2 thin under-IP discovery line deliberately not implemented in this PR. Do not merge to main without Windows exact-head build + packaged portable smoke and visual FAT at 100/150% DPI (up/down state, keyboard toggle, tab navigation, no flicker). No claim of physical relay qualification from code CI.

Copy link
Copy Markdown
Owner Author

Disposition: Superseded (fully preserved UI checkpoint) — safe closure of intermediate historical PR tracking, not an application merge or release acceptance.

Canonical replacement: #649 retains the cumulative field-accepted IED card/Command Dock UI ancestry; current #727/#729 integrated RC at 817c3910e8223fa2ac531a4426ada5d2d4bbbe50 retains the relevant code behavior. Original PR head d14a6e309326f8c22e2d812f9fff29bef719eb80 is an exact ancestor of the RC (GitHub compare ahead=807, behind=0).

Unique delta: Phase-1 Command Dock transparent expander header / operator-white glyphs. Evidence: All three non-production files are byte-identical in RC: docs/CHECKPOINT_COMMAND_DOCK_FAT_UI_PHASE1_2026-10-20.md, tests/ARSAS.Tests/MaterialIconConsistencyTests.cs, tests/ARSAS.Tests/P109XCommandDockWhiteGlyphRegressionTests.cs. The current App.xaml still defines CommandDockTransparentHeaderExpander and MainWindow.xaml still applies it to the original CommandPanelExpander. It keeps the original Expanded/Collapsed handlers and power SVG semantics. The original PR commit/branch remains recoverable, and original tests/checkpoints have not been deleted.

Safety: The current RC production files evolved after the PR, so we verified surviving specific behavior, not falsely claimed blob-identical entire XAML/model files. This action changes no runtime code, no main, no stable v1.6.42, no ARIEC engine pin and no R7/R10 or physical FAT policy.

Follow-up: Verify native glyph/chevron/operator visual acceptance under current GUI theme before any source promotion; #730/#732 remain active. Existing #649 and physically gated #729 remain OPEN. Do not revive/rebase older UI heads over current SSOT/Write/SMV.

@masarray masarray closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant