Skip to content

P2 GUI field fix: GOOSE visible events, unclipped workspace, SNTP IPv4, Browser expansion memory - #736

Merged
masarray merged 16 commits into
ui/rc0-p0-p1-visual-preview-20261024from
fix/rc0-goose-sntp-browser-state-20261025
Oct 24, 2026
Merged

masarray merged 16 commits into
ui/rc0-p0-p1-visual-preview-20261024from
fix/rc0-goose-sntp-browser-state-20261025

Conversation

@masarray

Copy link
Copy Markdown
Owner

P2: Field screenshot fixes — GOOSE timeline, SNTP IP picker and IED Browser state

Base: current integrated GUI PR #733, head 48808f. Change set is presentation only, not the ARIEC engine.

Findings / fixes

  • GOOSE apparent 0 messages with received 79 frames: raw Ethernet frames and meaningful GOOSE timeline rows are different counters. The existing 500-event ring, bounded 512 pending queue, 48-row dispatcher flush, fingerprint coalescing and strict identity-scoped collection views already exist; the default filter selected-only silently excluded unmapped publishers. Default to All IED GOOSE signals, preserve exact selected-IED identity authority when user explicitly selects it, and explain an empty scoped timeline rather than claiming zero capture. No guessing publisher identity from MAC/IP.
  • GOOSE bottom clipped: LiteView MinHeight=560 forced a taller child than available above the shared Dock at smaller DPI heights. Remove fixed min-height and default GOOSE Command Dock to collapsed (operator override retained independently) so event timeline and DataSet Inspector have the viewport.
  • SNTP picker: canonical record objects leaked the runtime type text under the shared ComboBox selection template, despite DisplayMemberPath. Render only local IPv4 address through SntpNetworkBinding.ToString; independent NTP binding/control logic untouched.
  • IED Browser expansion: persist bounded per-DeviceId tree expanded keys and per-exact-page section expansion, including explicit user collapses, across model rebuild and IED switches. First-open 'Information received in last Report' and 'Information received in last GOOSE' sections default collapsed; explicit user expansion is restored. Never cache MMS values or stale Report frames.
  • Regression: new focused tests for user-visible rendering, default/remembered expansion and view-only GOOSE scope/queue invariants.

Safety

  • No changes to protocol, decoder, MMS reads/writes, IED control, GOOSE stream ingress, SNTP server transport, or release packaging.
  • No fake association of unresolved GOOSE publisher frames with the currently selected IED.
  • UI thread only for WPF ListCollectionView and projections; no duplicate background capture/worker introduced.
  • Build/test exact SHA, on-device screenshots at 100/125/150% DPI, verify selected-IED with and without verified model identity.
  • Release owner must preserve existing R7/R10 interoperability and physical approval gates.
  • Keep this draft until CI and operator GUI acceptance; integrate this single hotfix into RC0 GUI RELEASE CANDIDATE: integrate proven P0+P1 cool-blue UX (#730) #733 before RC0 GUI RELEASE CANDIDATE: integrate proven P0+P1 cool-blue UX (#730) #733 targets RC; no direct merge into RC/main.

This PR is a field GUI follow-up to #730 and fixes feedback from 2026-10-25 screenshots.

…ll-publisher default and collapsed status sections
…ll-publisher default and collapsed status sections
…ll-publisher default and collapsed status sections
…ll-publisher default and collapsed status sections
…ll-publisher default and collapsed status sections
…ll-publisher default and collapsed status sections
…default collapsed last-report and memory-safe reset
…default collapsed last-report and memory-safe reset
@masarray
masarray marked this pull request as ready for review October 24, 2026 21:41
@masarray
masarray merged commit 4b1614b into ui/rc0-p0-p1-visual-preview-20261024 Oct 24, 2026
4 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T21:42:36.240588Z f2a9b40 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant