Repository navigation
P0 discovery: stop dead optional probes after association fault without losing evidence - #184
Merged
masarray merged 2 commits intoOct 15, 2026
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 910adaa5d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to merged #183, main
0081a52d73036fb4ebeec7be63a2d6b2d88cb060.Root cause: when an exchange times out or transport faults, the single MMS association is closed, yet optional Domain/LN type/DataSet/RCB loops still construct potentially thousands of doomed requests, misreporting them as failed probes and wasting CPU. With the runtime-confirmed wire budget in #183, this is visible as a large gap between attempted enrichment and actual sends.
Change only existing
MmsLiveDiscoveryClient::discoverflow: if the association becomes unusable, stop optional phases and loops at their boundaries. Preserve successfully observed Domain/NamedVariable evidence, keep the failing probe and its exact diagnostic, retain canonical structural DataSet/RCB inventory, and do not synthesize unattempted probe outcomes. Retain existing policy for recoverable MMS application errors while the association remains active.Regression covers failed GVA + skipped DataSet/RCB, two-domain mid-enumeration transport timeout with first domain preserved, exact confirmed-send counts, and no writes/timers/second engine. Test C++ and native Qt on exact head, naming guard, reviews before merge. No claim of physical IED interoperability or negotiated concurrent MMS pipeline.