Skip to content

feat: create tests #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nazarii-Lesniak wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: create tests #1096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62c0cf7
feat: create tests
Nazarii-Lesniak Jun 2, 2026
3412e74
fix: update the test to the test requirement
Nazarii-Lesniak Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/splitInteger.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,19 @@
const splitInteger = require('./splitInteger');

test(`should split a number into equal parts
if a value is divisible by a numberOfParts`, () => {});
if a value is divisible by a numberOfParts`, () => {
expect(splitInteger(6, 2)).toEqual([3, 3]);
});

test(`should return a part equals to a value
when splitting into 1 part`, () => {});
when splitting into 1 part`, () => {
expect(splitInteger(8, 1)).toEqual([8]);
});

test('should sort parts ascending if they are not equal', () => {});
test('should sort parts ascending if they are not equal', () => {
expect(splitInteger(17, 4)).toEqual([4, 4, 4, 5]);
});

test('should add zeros if value < numberOfParts', () => {});
test('should add zeros if value < numberOfParts', () => {
Comment on lines 18 to +19
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test description says 'should add zeros if value < numberOfParts' but this test uses splitInteger(32, 6) where value (32) is NOT less than numberOfParts (6). The expected output [5, 5, 5, 5, 6, 6] doesn't contain zeros. The description needs to be corrected to match what this test actually validates, or the test case should be changed to test the 'value < numberOfParts' scenario.

expect(splitInteger(2, 6)).toEqual([0, 0, 0, 0, 1, 1]);
});
Loading